test: wallet_bumpfee assertion fixup #18540

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:bumpfee-test-assertion-fixup changing 1 files +1 −2

jonatack commented at 4:40 PM on April 6, 2020: member

Follow-up to #18516 to fix up an assertion as per suggested change in #18516 (review).
test: wallet_bumpfee assertion fixup b224b4e7bd
DrahtBot added the label Tests on Apr 6, 2020

jonatack commented at 4:46 PM on April 6, 2020: member

Test output on (forced) error, with this change:

(bumpfee-test-assertion-fixup)$ test/functional/wallet_bumpfee.py 
...
TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 112, in main
    self.run_test()
  File "test/functional/wallet_bumpfee.py", line 84, in run_test
    test_dust_to_fee(self, rbf_node, dest_address)
  File "test/functional/wallet_bumpfee.py", line 261, in test_dust_to_fee
    raise AssertionError("Invalid tx vsize of {} (140-141 expected), full tx: {}".format(fulltx["vsize"], fulltx))
AssertionError: Invalid tx vsize of 139 (140-141 expected), full tx: {'txid': ...

jnewbery commented at 5:51 PM on April 6, 2020: member

ACK b224b4e7bd8c52bb70d933c1bc524c0fe87ac0c1

Thanks Jon!
MarcoFalke merged this on Apr 6, 2020
MarcoFalke closed this on Apr 6, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

jonatack

jnewbery

Labels

Tests

Linked (view graph)

#18516 test: relax bumpfee dust_to_fee txsize an extra vbyte