rpc: Make verifychain default values static, not depend on global args #18541

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-rpcStaticDefaults changing 1 files +6 −11

MarcoFalke commented at 4:55 PM on April 6, 2020: member
This fixes several issues:
- The documentation is not compile-time static and depends on run-time arguments, making it impossible to host it on a static resource like a website or pdf. See also a similar change in the wallet rpc code: #18499
- The same call (relying on default values) will run different code on different machines, depending on the command line args that were used to start the server. This might lead to hard-to-debug-remote issues.
This is a small behaviour change, and I will add release notes.
rpc: Make verifychain default values static, not depend on global args fad691cafe
DrahtBot added the label RPC/REST/ZMQ on Apr 6, 2020
DrahtBot commented at 12:58 AM on April 7, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18531 (rpc: Assert that RPCArg names are equal to CRPCCommand ones by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in src/rpc/blockchain.cpp:1095 in fad691cafe
```
1091 | @@ -1094,15 +1092,12 @@ static UniValue verifychain(const JSONRPCRequest& request)
1092 |                  },
1093 |              }.Check(request);
1094 |  
1095 | -    LOCK(cs_main);
1096 | +    const int check_level(request.params[0].isNull() ? DEFAULT_CHECKLEVEL : request.params[0].get_int());
```
theStack commented at 2:54 PM on April 7, 2020:

nit: should also use list initialization here ({....}), same as one line below

MarcoFalke commented at 3:49 PM on April 7, 2020:

That wouldn't compile

theStack commented at 5:44 PM on April 7, 2020:

Oh I see, DEFAULT_CHECKLEVEL has the wrong type -- unsigned even If the consuming function takes it as signed (for whatever reason).
theStack commented at 2:54 PM on April 7, 2020: member

Concept ACK
theStack approved
theStack commented at 5:45 PM on April 7, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/18541/commits/fad691cafe083743a26f434488990f060ae4ac45
promag commented at 10:50 PM on April 9, 2020: member

Code review ACK fad691cafe083743a26f434488990f060ae4ac45.
MarcoFalke merged this on Apr 10, 2020
MarcoFalke closed this on Apr 10, 2020
MarcoFalke deleted the branch on Apr 10, 2020
sidhujag referenced this in commit 16258a650c on Apr 13, 2020
deadalnix referenced this in commit 6620ec6c59 on Jan 14, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18499 rpc: Make rpc documentation not depend on call-time rpc args

rpc: Make verifychain default values static, not depend on global args #18541

Conflicts