test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction #18543

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-testFixes changing 1 files +4 −4
  1. MarcoFalke commented at 5:13 PM on April 6, 2020: member

    Node 0 creates a transaction in a block, and node 1 sends a spending transaction without properly syncing the utxo set.

    Fixes intermittent test failure in rpc_signrawtransaction

    test  2020-04-01T00:14:03.400000Z TestFramework (ERROR): JSONRPC error 
                                       Traceback (most recent call last):
                                         File "C:\projects\bitcoin\test\functional\test_framework\test_framework.py", line 112, in main
                                           self.run_test()
                                         File "C:\projects\bitcoin/test/functional/rpc_signrawtransaction.py", line 213, in run_test
                                           self.witness_script_test()
                                         File "C:\projects\bitcoin/test/functional/rpc_signrawtransaction.py", line 208, in witness_script_test
                                           self.nodes[1].sendrawtransaction(spending_tx_signed['hex'])
                                         File "C:\projects\bitcoin\test\functional\test_framework\coverage.py", line 47, in __call__
                                           return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
                                         File "C:\projects\bitcoin\test\functional\test_framework\authproxy.py", line 141, in __call__
                                           raise JSONRPCException(response['error'], status)
                                       test_framework.authproxy.JSONRPCException: bad-txns-inputs-missingorspent (-25)
    

    Full log: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/31864368

  2. MarcoFalke commented at 5:14 PM on April 6, 2020: member
  3. achow101 commented at 5:59 PM on April 6, 2020: member

    I think the same is needed above on line 189. Or maybe just change these to self.nodes[0]?

  4. test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction fa2251df5e
  5. MarcoFalke force-pushed on Apr 6, 2020
  6. MarcoFalke renamed this:
    test: Properly sync utxo set to avoid race
    test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction
    on Apr 6, 2020
  7. MarcoFalke commented at 6:20 PM on April 6, 2020: member

    Switched both to node[0] as suggested by @achow101

  8. DrahtBot added the label Tests on Apr 6, 2020
  9. achow101 commented at 8:16 PM on April 6, 2020: member

    ACK fa2251df5e3471e0d19d5d5c7780d34ee1498cee

  10. MarcoFalke merged this on Apr 6, 2020
  11. MarcoFalke closed this on Apr 6, 2020

  12. MarcoFalke deleted the branch on Apr 6, 2020
  13. DrahtBot locked this on Feb 15, 2022
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me