qt: Fix Window -> Minimize menu item #18549

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200406-fix-minimize changing 1 files +1 −1
  1. hebasto commented at 9:47 pm on April 6, 2020: member

    Now Window -> Minimize menu item is broken on Linux.

    Steps to reproduce:

    1. start bitcoin-qt
    2. activate Window -> Minimize menu item with a keyboard (not by a shortcut) or a mouse

    Expected behavior

    The main window gets minimized.

    Actual behavior

    The main window still unchanged. Even worse: the menu widget becomes a separate window:

    Screenshot from 2020-04-07 00-32-02

    This PR does not touch the macOS specific code as qApp->focusWindow() seems work on macOS flawlessly.

  2. qt: Fix Window -> Minimize menu item 56fe839e4e
  3. hebasto commented at 9:47 pm on April 6, 2020: member
    cc: @promag
  4. fanquake added the label GUI on Apr 6, 2020
  5. MarcoFalke commented at 11:29 pm on April 6, 2020: member
    Has this ever worked? When did it break?
  6. promag commented at 11:30 pm on April 6, 2020: member
    Tested ACK 56fe839e4e6d837b95b920a524570d11f7c3c5ce on bionic with qt 5.9.5.
  7. MarcoFalke added this to the milestone 0.20.0 on Apr 6, 2020
  8. promag commented at 0:03 am on April 7, 2020: member
    @MarcoFalke I don’t know, it was added in #14573, maybe it never worked right on linux.
  9. promag commented at 8:43 am on April 7, 2020: member
    @MarcoFalke I confirm that the problem always existed since it was introduced in 95a5a9fccb8b4296d2db1270a9798c359c9c1cf6.
  10. MarcoFalke merged this on Apr 7, 2020
  11. MarcoFalke closed this on Apr 7, 2020

  12. hebasto deleted the branch on Apr 7, 2020
  13. MarkLTZ referenced this in commit 3ec6a5c547 on Apr 9, 2020
  14. jasonbcox referenced this in commit 0e60c8d5b7 on Oct 13, 2020
  15. ftrader referenced this in commit e282d7c8b0 on Apr 14, 2021
  16. PastaPastaPasta referenced this in commit b05763a21f on Sep 17, 2021
  17. PastaPastaPasta referenced this in commit 05c94c713d on Sep 17, 2021
  18. PastaPastaPasta referenced this in commit 590ea9a24a on Sep 18, 2021
  19. thelazier referenced this in commit 56b70d4d6f on Sep 25, 2021
  20. DrahtBot locked this on Feb 15, 2022


hebasto MarcoFalke promag

Labels
GUI

Milestone
0.20.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me