Bitcoin-Qt: expand GCC Stack-Smashing Protector usage (non Windows) #1856

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:stack-protector_nonWindows changing 1 files +8 −7

Diapolo commented at 10:31 AM on September 22, 2012: none
This patch currently excludes our Windows executable!
- change to use -fstack-protector-all
- the minimum size of buffers (i.e. arrays) that will receive stack smashing protection was changed to 1 byte (GCC default: 8)
- warn about functions that will not be protected against stack smashing by adding -Wstack-protector
See #1674 for full discussion on the Windows issue! This should be safe to merge, but we can wait until the pull tester did it's job!

Bitcoin-Qt: expand GCC Stack-Smashing Protector usage (non Windows)

This patch currently excludes our Windows executable!

- change to use -fstack-protector-all
- the minimum size of buffers (i.e. arrays) that will receive stack
  smashing protection was changed to 1 byte (GCC default: 8)
- warn about functions that will not be protected against stack
  smashing by adding -Wstack-protector

807f3e83ba

BitcoinPullTester commented at 1:31 AM on September 23, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/807f3e83ba1c5299587c1c94555cd02f47dc2738 for binaries and test log.
laanwj referenced this in commit 6a34def27e on Sep 25, 2012
laanwj merged this on Sep 25, 2012
laanwj closed this on Sep 25, 2012
KolbyML referenced this in commit 1bbb906059 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

Linked (view graph)

#1674 enable full GCC Stack-smashing protection for all OSes