gui: Fix leak in CoinControlDialog::updateView #18578

1. 
   promag commented at 10:29 pm on April 9, 2020: member

   Taken from #17457, the first commit is a similar to 88a94f7bb8ba2b0257315d70717f9af928ca6561 but for test binary, and the second commit fixes a leak where CCoinControlWidgetItem are unnecessarily created and leaked.
2. fanquake added the label GUI on Apr 9, 2020
3. promag renamed this:
   gui: Fix itemWalletAddress leak when not tree mode
   gui: Fix leak in CoinControlDialog::updateView
   on Apr 11, 2020
4. 
   promag commented at 0:16 am on May 4, 2020: member

   @jonasschnelli friendly ping.
5. 
   hebasto commented at 0:20 am on May 4, 2020: member

   Concept ACK.
6. 
   hebasto commented at 0:42 am on May 4, 2020: member

   @promag How could I observe the Qt warning that is fixed by f95ebe7c215fd8cb00f6ff69722506227f7afa6e?
7. 
   hebasto commented at 2:53 am on May 4, 2020: member

   a3a02ddea936109cc43338429d4f20efe4cdee99:

   This constructor https://github.com/bitcoin/bitcoin/blob/a3a02ddea936109cc43338429d4f20efe4cdee99/src/qt/coincontroldialog.h#L34 is unused now and could be removed.

8. promag force-pushed on May 4, 2020
9. 
   promag commented at 9:13 am on May 4, 2020: member

   @promag How could I observe the Qt warning that is fixed by f95ebe7?

   I’ve seen the warning while working on #17457.

   is unused now and could be removed.

   Thanks, removed.

10. 
    hebasto commented at 10:41 am on May 4, 2020: member

    @promag How could I observe the Qt warning that is fixed by f95ebe7?

    I’ve seen the warning while working on #17457.

    Mind providing steps to reproduce? I’ve already tried to run test_bitcoin-qt with QT_QPA_PLATFORM=xcb and with unset QT_QPA_PLATFORM, and did not spot “Cannot queue arguments of type size_t” warning. I’m so curious because it could be the first qRegisterMetaType in the qt/test/test_main.cpp.

    Another suggestion: if this commit is related to #17457, maybe move it to #17457?

11. 
    jonasschnelli commented at 10:48 am on May 4, 2020: contributor

    The first commit looks indeed after a memory leak fix. How relevant is the second commit f95ebe7c215fd8cb00f6ff69722506227f7afa6e?
12. gui: Fix itemWalletAddress leak when not tree mode e8123eae40
13. promag force-pushed on May 4, 2020
14. 
    promag commented at 11:06 am on May 4, 2020: member

    @jonasschnelli @hebasto dropped f95ebe7c215fd8cb00f6ff69722506227f7afa6e and rebased.
15. hebasto approved
16. 
    hebasto commented at 11:09 am on May 4, 2020: member

    ACK e8123eae40eb264bbb71007d0eb074901f0e2fe5, tested on Linux Mint 19.3.
17. luke-jr approved
18. 
    luke-jr commented at 3:19 am on May 5, 2020: member

    utACK a3a02ddea936109cc43338429d4f20efe4cdee99
19. jonasschnelli added the label Needs backport (0.20) on May 13, 2020
20. jonasschnelli added this to the milestone 0.20.0 on May 13, 2020
21. 
    jonasschnelli commented at 8:12 am on May 13, 2020: contributor

    utACK e8123eae40eb264bbb71007d0eb074901f0e2fe5
22. jonasschnelli merged this on May 13, 2020
23. jonasschnelli closed this on May 13, 2020

    ---

24. promag deleted the branch on May 13, 2020
25. sidhujag referenced this in commit 4460ecfc57 on May 14, 2020
26. fanquake referenced this in commit 63e957adff on May 14, 2020
27. fanquake removed the label Needs backport (0.20) on May 14, 2020
28. fanquake referenced this in commit 315ae14f3f on May 15, 2020
29. MarcoFalke referenced this in commit 17bdf2afae on May 15, 2020
30. MarkLTZ referenced this in commit a4b5be92d9 on Nov 7, 2020
31. deadalnix referenced this in commit 225d8df38a on Jan 28, 2021
32. backpacker69 referenced this in commit 20f91cffcf on Mar 28, 2021
33. PastaPastaPasta referenced this in commit 66a9fa0c7c on Jun 27, 2021
34. PastaPastaPasta referenced this in commit 472a487b3b on Jun 28, 2021
35. PastaPastaPasta referenced this in commit 0863d79bb4 on Jun 29, 2021
36. PastaPastaPasta referenced this in commit b03649bacf on Jul 1, 2021
37. PastaPastaPasta referenced this in commit 7434733e47 on Jul 1, 2021
38. PastaPastaPasta referenced this in commit 1421e714ed on Jul 14, 2021
39. PastaPastaPasta referenced this in commit 8af8bbc20e on Jul 15, 2021
40. DrahtBot locked this on Feb 15, 2022

Contributors
promag hebasto jonasschnelli luke-jr

Labels
GUI

Milestone
0.20.0