test: Try once more when RPC connection fails on Windows #18596

1. 
   MarcoFalke commented at 3:51 pm on April 11, 2020: member

   Fixes: #18548
2. fanquake added the label Tests on Apr 11, 2020
3. MarcoFalke force-pushed on Apr 11, 2020
4. MarcoFalke renamed this:
   [WIP] test: Revert windows workaround temporarily
   test: Try once more when RPC connection fails on Windows
   on Apr 12, 2020
5. MarcoFalke force-pushed on Apr 12, 2020
6. MarcoFalke force-pushed on Apr 12, 2020
7. MarcoFalke force-pushed on Apr 12, 2020
8. MarcoFalke force-pushed on Apr 12, 2020
9. MarcoFalke force-pushed on Apr 12, 2020
10. cirrus: Bump freebsd to 12.1 fae760f2b2
11. test: Remove python 3.4 workaround fa9f4f663c
12. test: Document why connection is re-constructed on windows faa655731e
13. test: Try once more when RPC connection fails on Windows fab9899204
14. MarcoFalke force-pushed on Apr 12, 2020
15. 
    MarcoFalke commented at 4:55 pm on April 12, 2020: member

    Fixed. Tests should now run smoothly again on Linux, Windows and Freebsd.

    Freebsd run: https://cirrus-ci.com/build/5888962329837568

16. in test/functional/test_framework/authproxy.py:110 in fab9899204

    107             self.__conn.request(method, path, postdata, headers)
    108             return self._get_response()
    109-        except http.client.BadStatusLine as e:
    110-            if e.line == "''":  # if connection was closed, try again
    111+        except (BrokenPipeError, ConnectionResetError):
    112+            # Python 3.5+ raises BrokenPipeError when the connection was reset
    

    ---

    ---

    

    hebasto commented at 9:01 am on April 13, 2020:

    Is such behavior Windows-specific?

    ---

    

    MarcoFalke commented at 10:18 am on April 13, 2020:

    Please include the commit you are referring to in the comment. This pull shouldn’t change behaviour on non-windows machines in authproxy.
17. in test/functional/test_framework/authproxy.py:103 in fab9899204

    100@@ -101,23 +101,26 @@ def _request(self, method, path, postdata):
    101         if os.name == 'nt':
    102             # Windows somehow does not like to re-use connections
    103             # TODO: Find out why the connection would disconnect occasionally and make it reusable on Windows
    

    ---

    ---

    

    hebasto commented at 9:03 am on April 13, 2020:

    Are these lines still relevant?

    ---

    

    MarcoFalke commented at 10:19 am on April 13, 2020:

    Yes, why wouldn’t they?
18. hebasto approved
19. 
    hebasto commented at 1:30 pm on April 13, 2020: member

    ACK fab98992043f47fa7240d7c1217920d0c4f783a2, I have reviewed the code and it looks OK, I agree it can be merged.
20. MarcoFalke merged this on Apr 13, 2020
21. MarcoFalke closed this on Apr 13, 2020

    ---

22. MarcoFalke deleted the branch on Apr 13, 2020
23. deadalnix referenced this in commit dff6b6a293 on Sep 22, 2020
24. PastaPastaPasta referenced this in commit 086f9346fd on Sep 25, 2021
25. PastaPastaPasta referenced this in commit af79508f7e on Sep 28, 2021
26. kittywhiskers referenced this in commit 37b812c370 on Oct 12, 2021
27. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke hebasto

Labels
Tests