wallet: Refactor WalletRescanReserver to use wallet reference #18601

1. 
   promag commented at 11:45 pm on April 11, 2020: member

   Simple refactor to WalletRescanReserver to use wallet reference instead of pointer.

   Complements #18259.

2. DrahtBot added the label GUI on Apr 11, 2020
3. DrahtBot added the label RPC/REST/ZMQ on Apr 11, 2020
4. DrahtBot added the label Tests on Apr 11, 2020
5. DrahtBot added the label Wallet on Apr 11, 2020
6. fanquake removed the label GUI on Apr 11, 2020
7. fanquake removed the label RPC/REST/ZMQ on Apr 11, 2020
8. fanquake removed the label Tests on Apr 11, 2020
9. MarcoFalke renamed this:
   wallet: Refactor WalletRescanReserver constructor to take wallet refe…
   wallet: Refactor WalletRescanReserver to use wallet reference
   on Apr 12, 2020
10. MarcoFalke added the label Refactoring on Apr 12, 2020
11. 
    DrahtBot commented at 4:11 am on April 12, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18592 (rpc: replace raw pointers with shared_ptrs by brakmic)
    • #17954 (wallet: Remove calls to Chain::Lock methods by ryanofsky)
    • #16127 (More thread safety annotation coverage by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. promag force-pushed on Apr 12, 2020
13. 
    promag commented at 10:47 am on April 12, 2020: member

    @MarcoFalke fixed.
14. 
    MarcoFalke commented at 12:29 pm on April 12, 2020: member

    ACK 8f1b82561cae2fcc78bce6ca7bab81cd9561cf14
15. DrahtBot added the label Needs rebase on Apr 14, 2020
16. 
    MarcoFalke commented at 11:38 am on April 19, 2020: member

    @promag Are you still working on this? If not, it can be closed.
17. wallet: Refactor WalletRescanReserver to use wallet reference fc289b7898
18. promag force-pushed on Apr 19, 2020
19. 
    promag commented at 1:06 pm on April 19, 2020: member

    @MarcoFalke rebased.
20. DrahtBot removed the label Needs rebase on Apr 19, 2020
21. 
    MarcoFalke commented at 1:55 pm on April 19, 2020: member

    ACK fc289b7898fb90d4800675b69c0bb9b42df5599f
22. MarcoFalke merged this on Apr 19, 2020
23. MarcoFalke closed this on Apr 19, 2020

    ---

24. promag deleted the branch on Apr 19, 2020
25. jasonbcox referenced this in commit bdcfca27e8 on Sep 22, 2020
26. DrahtBot locked this on Feb 15, 2022

Contributors
promag DrahtBot MarcoFalke

Labels
Refactoring Wallet