Simple refactor to WalletRescanReserver to use wallet reference instead of pointer.
Complements #18259.
wallet: Refactor WalletRescanReserver to use wallet reference #18601
pull promag wants to merge 1 commits into bitcoin:master from promag:2020-04-walletrescanreserver changing 6 files +23 −23-
promag commented at 11:45 PM on April 11, 2020: member
- DrahtBot added the label GUI on Apr 11, 2020
- DrahtBot added the label RPC/REST/ZMQ on Apr 11, 2020
- DrahtBot added the label Tests on Apr 11, 2020
- DrahtBot added the label Wallet on Apr 11, 2020
- fanquake removed the label GUI on Apr 11, 2020
- fanquake removed the label RPC/REST/ZMQ on Apr 11, 2020
- fanquake removed the label Tests on Apr 11, 2020
- MarcoFalke renamed this:
wallet: Refactor WalletRescanReserver constructor to take wallet refe…
wallet: Refactor WalletRescanReserver to use wallet reference
on Apr 12, 2020 - MarcoFalke added the label Refactoring on Apr 12, 2020
-
DrahtBot commented at 4:11 AM on April 12, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18592 (rpc: replace raw pointers with shared_ptrs by brakmic)
- #17954 (wallet: Remove calls to Chain::Lock methods by ryanofsky)
- #16127 (More thread safety annotation coverage by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- promag force-pushed on Apr 12, 2020
-
promag commented at 10:47 AM on April 12, 2020: member
@MarcoFalke fixed.
-
MarcoFalke commented at 12:29 PM on April 12, 2020: member
ACK 8f1b82561cae2fcc78bce6ca7bab81cd9561cf14
- DrahtBot added the label Needs rebase on Apr 14, 2020
-
MarcoFalke commented at 11:38 AM on April 19, 2020: member
@promag Are you still working on this? If not, it can be closed.
-
wallet: Refactor WalletRescanReserver to use wallet reference fc289b7898
- promag force-pushed on Apr 19, 2020
-
promag commented at 1:06 PM on April 19, 2020: member
@MarcoFalke rebased.
- DrahtBot removed the label Needs rebase on Apr 19, 2020
-
MarcoFalke commented at 1:55 PM on April 19, 2020: member
ACK fc289b7898fb90d4800675b69c0bb9b42df5599f
- MarcoFalke merged this on Apr 19, 2020
- MarcoFalke closed this on Apr 19, 2020
- promag deleted the branch on Apr 19, 2020
- jasonbcox referenced this in commit bdcfca27e8 on Sep 22, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels