appveyor: Remove clcache #18640

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-appveyorNoSlowCache changing 1 files +1 −8
  1. MarcoFalke commented at 0:18 am on April 15, 2020: member
    The build time without cache seems to be 47 minutes and with cache 46 minutes. Maybe we can save more time by not installing clcache.
  2. appveyor: Remove clcache fac0c8db9f
  3. MarcoFalke force-pushed on Apr 15, 2020
  4. fanquake added the label Tests on Apr 15, 2020
  5. MarcoFalke commented at 2:07 am on April 15, 2020: member

    The build https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32183943 finished in 44 minutes

    Anything left to do here?

  6. in .appveyor.yml:80 in fac0c8db9f
    73-- ps:  fsutil behavior set disablelastaccess 0 # Enable Access time feature on Windows (for clcache)
    74 build_script:
    75-- cmd: msbuild /p:TrackFileAccess=false /p:CLToolExe=clcache.exe build_msvc\bitcoin.sln /m /v:q /nologo
    76+- cmd: msbuild /p:TrackFileAccess=false build_msvc\bitcoin.sln /m /v:q /nologo
    77 after_build:
    78-- ps:  fsutil behavior set disablelastaccess 1 # Disable Access time feature on Windows (better performance)
    


    sipa commented at 6:46 am on April 15, 2020:
    Removing this line seems unrelated.

    MarcoFalke commented at 12:49 pm on April 15, 2020:

    See this build here: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/32194931

    So with this line added, it slowed down the build. Or at least didn’t speed it up, so I don’t feel comfortable keeping it.

    Test code should be minimal, easy to read and easy to write. Having a line say “better performance” without any data to back up the claim doesn’t help.

  7. MarcoFalke force-pushed on Apr 15, 2020
  8. MarcoFalke commented at 7:25 pm on April 15, 2020: member
    I am going to go ahead and merge this. If someone finds a way to speed things up, great, we can take them. Though, it doesn’t look like clcache speeds things up at all for us. This might be a configuration error or it might be vaporvare, and keeping in the code in the appveyor yaml isn’t helping anyone.
  9. MarcoFalke merged this on Apr 15, 2020
  10. MarcoFalke closed this on Apr 15, 2020

  11. MarcoFalke deleted the branch on Apr 15, 2020
  12. sidhujag referenced this in commit fb4fcec1f7 on Apr 15, 2020
  13. MarcoFalke referenced this in commit faf5e256c5 on Jul 10, 2020
  14. fanquake referenced this in commit 1fd9cd2cb4 on Aug 11, 2020
  15. MarcoFalke referenced this in commit 28a9df7d76 on Aug 11, 2020
  16. backpacker69 referenced this in commit c6b8411de6 on Sep 8, 2020
  17. Bushstar referenced this in commit 0823a753f7 on Oct 21, 2020
  18. Platinumwrist referenced this in commit 05e2740d92 on Oct 25, 2020
  19. DrahtBot locked this on Feb 15, 2022


MarcoFalke sipa

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-24 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me