Was searching through the code for places that read from the wallet after startup (since most wallet items are read at startup in LoadWallet)
walletdb.h: remove dead code #1871
pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:wallet-deadcode changing 1 files +0 −30-
jgarzik commented at 2:18 AM on September 27, 2012: contributor
-
walletdb.h: remove dead code 189eb6a989
-
laanwj commented at 6:50 AM on September 27, 2012: member
I'm all for removing dead code. It will only bitrot if it is unused and untested.
Maybe add a comment, that the Read* variants have been removed but can be found in git history. It is possible that eventually we don't want to read everything into memory anymore at startup.
Edit: though on the other hand, we do really want to get rid of the random-access read methods, to support append-only wallet formats.
-
BitcoinPullTester commented at 10:38 AM on September 27, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/189eb6a989674e384d65397befb6b1050789df97 for binaries and test log.
-
sipa commented at 2:00 PM on September 28, 2012: member
ACK. @laanwj even with an append-only wallet format, I suspect (at least initially) we'll load the entire wallet into memory anyway. Either we do that at the application level (have an iterator process all entries in the wallet at startup, like now), or at a thin layer beneath it that stores the key-value pairs in memory.
-
laanwj commented at 9:35 PM on September 28, 2012: member
ACK
-
gavinandresen commented at 11:55 PM on September 28, 2012: contributor
ACK. Yay less code!
- jgarzik referenced this in commit 3e37e7eca4 on Sep 29, 2012
- jgarzik merged this on Sep 29, 2012
- jgarzik closed this on Sep 29, 2012
- jgarzik deleted the branch on Aug 24, 2014
- KolbyML referenced this in commit 3c05a7bd2d on Dec 5, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors