Regression introduced today with p2p_filter.py? #18711

issue jonatack opened this issue on April 20, 2020

jonatack commented at 4:58 PM on April 20, 2020: member

in #18544 it seems:

TestFramework (INFO): Check that sending "filteradd" if no filter is set is treated as misbehavior (+100)
TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/test_framework.py", line 112, in main
    self.run_test()
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/p2p_filter.py", line 120, in run_test
    assert_equal(self.nodes[0].getpeerinfo()[0]['banscore'], 0)
  File "/home/travis/build/jonatack/bitcoin/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/util.py", line 46, in assert_equal
    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(100 == 0)

jonatack added the label Bug on Apr 20, 2020
jonatack commented at 5:00 PM on April 20, 2020: member

Seeing this in the travis ci builds; pinging @theStack.
jonatack commented at 5:02 PM on April 20, 2020: member

See https://travis-ci.org/github/bitcoin/bitcoin/jobs/677193293#L3665
theStack commented at 5:15 PM on April 20, 2020: member

Yes, I can confirm that it fails on master -- that was apparently introduced through merging of #18544. The problem is that the "misbehaviour" check in #18544 uses the method of checking banscore via getpeerinfo() and assumes a banscore of 0 near the end of the test: https://github.com/bitcoin/bitcoin/blob/56d2ff8a8fc52676a22163f804a9f1a5415b4b71/test/functional/p2p_filter.py#L120-L122 while another commit merged in-between introduced misbehaviour before, increasing the banscore: https://github.com/bitcoin/bitcoin/blob/56d2ff8a8fc52676a22163f804a9f1a5415b4b71/test/functional/p2p_filter.py#L68-L70

PR #18672 includes a fix for the problem, by simply also using assert_debug_log for detecting misbehaviour.
brakmic commented at 10:07 AM on April 21, 2020: contributor

Same problem with my PR: https://travis-ci.org/github/bitcoin/bitcoin/builds/677464990

Thanks for fixing it, @theStack
MarcoFalke closed this on Apr 21, 2020
sidhujag referenced this in commit f398e24e39 on Apr 23, 2020
DrahtBot locked this on Feb 15, 2022
vijaydasmp referenced this in commit a2fb3bed58 on May 6, 2023

Contributors

Labels

Linked (view graph)

#18544 net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear')#18672 test: add further BIP37 size limit checks to p2p_filter.py