refactor: Make CCheckQueue RAII-styled #18731

pull hebasto wants to merge 7 commits into bitcoin:master from hebasto:200421-queue-raii changing 9 files +95 −150
  1. hebasto commented at 12:33 AM on April 22, 2020: member

    This PR:

    • makes CCheckQueue RAII-styled
    • gets rid of two global variables:
      • scriptcheckqueue
      • g_parallel_script_checks

    This PR is based on #18710, therefore only the last two commits should be considered.

  2. fanquake added the label Refactoring on Apr 22, 2020
  3. DrahtBot commented at 10:12 AM on April 22, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20487 (draft: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift)
    • #20323 (tests: Create or use existing properly initialized NodeContexts by dongcarl)
    • #20228 (addrman: Make addrman a top-level component by jnewbery)
    • #19935 (Move SaltedHashers to separate file and add some new ones by achow101)
    • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)
    • #19438 (Introduce deploymentstatus by ajtowns)
    • #19183 ([WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Needs rebase on Apr 22, 2020
  5. hebasto marked this as a draft on Apr 25, 2020
  6. hebasto renamed this:
    refactor: Make CCheckQueue RAII-styled
    [WIP] refactor: Make CCheckQueue RAII-styled
    on Apr 25, 2020
  7. promag commented at 10:52 PM on April 26, 2020: member

    Concept ACK RAII style.

    Need to fix test/fuzz/checkqueue.cpp in lines 41 and 42.

  8. hebasto force-pushed on Apr 28, 2020
  9. hebasto renamed this:
    [WIP] refactor: Make CCheckQueue RAII-styled
    refactor: Make CCheckQueue RAII-styled
    on Apr 28, 2020
  10. hebasto marked this as ready for review on Apr 28, 2020
  11. hebasto commented at 7:31 PM on April 28, 2020: member

    Rebased ba61343f43f8d91c160d698b3db11fc9d34e81eb -> 3553bde5b160ee243bce725d0b0165887a272136 (pr18731.01 -> pr18731.02) ~and ready for review.~

  12. DrahtBot removed the label Needs rebase on Apr 28, 2020
  13. hebasto marked this as a draft on Apr 28, 2020
  14. hebasto renamed this:
    refactor: Make CCheckQueue RAII-styled
    [WIP] refactor: Make CCheckQueue RAII-styled
    on Apr 28, 2020
  15. hebasto force-pushed on Apr 28, 2020
  16. hebasto force-pushed on May 1, 2020
  17. hebasto commented at 3:43 AM on May 1, 2020: member

    Updated 3553bde5b160ee243bce725d0b0165887a272136 -> 01be64d1305e5b30867e3955d7cdcd036e7f8381 (pr18731.02 -> pr18731.04, diff):

    • copy constructor and copy assignment are disabled

    And this PR is ready for review, finally.

  18. hebasto marked this as ready for review on May 1, 2020
  19. hebasto renamed this:
    [WIP] refactor: Make CCheckQueue RAII-styled
    refactor: Make CCheckQueue RAII-styled
    on May 1, 2020
  20. DrahtBot added the label Needs rebase on May 23, 2020
  21. hebasto force-pushed on May 26, 2020
  22. hebasto commented at 5:51 PM on May 26, 2020: member

    Rebased 01be64d1305e5b30867e3955d7cdcd036e7f8381 -> 3fa858781b0cf753a2c7901a386d3fc8f5f11e3a (pr18731.04 -> pr18731.05) due to the conflict with #18698.

  23. DrahtBot removed the label Needs rebase on May 26, 2020
  24. DrahtBot added the label Needs rebase on May 28, 2020
  25. hebasto force-pushed on May 28, 2020
  26. hebasto commented at 8:19 AM on May 28, 2020: member

    Rebased 3fa858781b0cf753a2c7901a386d3fc8f5f11e3a -> aad6c472415264a7ee93aeab1a461181ee96ad0c (pr18731.05 -> pr18731.06) due to the conflict with #16127.

  27. DrahtBot removed the label Needs rebase on May 28, 2020
  28. hebasto closed this on Jun 2, 2020
  29. hebasto reopened this on Jun 2, 2020
  30. DrahtBot added the label Needs rebase on Jun 2, 2020
  31. hebasto force-pushed on Jun 4, 2020
  32. hebasto commented at 9:32 AM on June 4, 2020: member

    Rebased aad6c472415264a7ee93aeab1a461181ee96ad0c -> ec0522406675dae9e88b13f5ee82a2311a547fdf (pr18731.06 -> pr18731.07) due to the conflict with #18792.

  33. DrahtBot removed the label Needs rebase on Jun 4, 2020
  34. DrahtBot added the label Needs rebase on Jun 4, 2020
  35. hebasto force-pushed on Jun 4, 2020
  36. hebasto commented at 2:35 PM on June 4, 2020: member

    Rebased ec0522406675dae9e88b13f5ee82a2311a547fdf -> 894b3e3e2769ea3e51cc62bd52bcda04c81b853e (pr18731.07 -> pr18731.08) due to the conflict with #19142.

  37. DrahtBot removed the label Needs rebase on Jun 4, 2020
  38. DrahtBot added the label Needs rebase on Jun 5, 2020
  39. hebasto force-pushed on Jun 5, 2020
  40. hebasto commented at 5:10 AM on June 5, 2020: member

    Rebased 894b3e3e2769ea3e51cc62bd52bcda04c81b853e -> d0ac4468e6911acc9cc8e82736782ca80f42a18c (pr18731.08 -> pr18731.09) due to the conflict with #18758.

  41. DrahtBot removed the label Needs rebase on Jun 5, 2020
  42. hebasto force-pushed on Jun 6, 2020
  43. hebasto commented at 6:40 AM on June 6, 2020: member

    Rebased d0ac4468e6911acc9cc8e82736782ca80f42a18c -> 6f224c64de16f1d8badc8284ce6cf96d83c40d45 (pr18731.09 -> pr18731.10) due to the conflict with #18710.

  44. DrahtBot added the label Needs rebase on Jul 28, 2020
  45. hebasto force-pushed on Jul 29, 2020
  46. hebasto commented at 8:32 AM on July 29, 2020: member

    Rebased 6f224c64de16f1d8badc8284ce6cf96d83c40d45 -> 45ba39aa6d61b3e6ccef0b265c27f56de209b5b6 (pr18731.10 -> pr18731.11) due to the conflicts with #18637 and #19589.

  47. DrahtBot removed the label Needs rebase on Jul 29, 2020
  48. DrahtBot added the label Needs rebase on Jul 30, 2020
  49. hebasto force-pushed on Jul 31, 2020
  50. hebasto commented at 11:23 AM on July 31, 2020: member

    Rebased 45ba39aa6d61b3e6ccef0b265c27f56de209b5b6 -> f62b22af87390719e09163df093b6a9059ad151c (pr18731.11 -> pr18731.12) due to the conflicts with #18011 and #19604.

  51. DrahtBot removed the label Needs rebase on Jul 31, 2020
  52. hebasto force-pushed on Aug 21, 2020
  53. hebasto commented at 6:29 AM on August 21, 2020: member

    Rebased f62b22af87390719e09163df093b6a9059ad151c -> 7a6ad64160c15cb9a77af1a0dcced476d0a08bda (pr18731.12 -> pr18731.13) on top of #19710 and #18710 to prevent merge conflicts.

  54. DrahtBot added the label Needs rebase on Aug 31, 2020
  55. hebasto force-pushed on Aug 31, 2020
  56. hebasto commented at 8:57 AM on August 31, 2020: member

    Rebased 7a6ad64160c15cb9a77af1a0dcced476d0a08bda -> e5a82deda64a11f03c48a6fcaadb78ec3502745f (pr18731.13 -> pr18731.14) due to the conflicts with #19710 and #19826.

  57. DrahtBot removed the label Needs rebase on Aug 31, 2020
  58. DrahtBot added the label Needs rebase on Sep 23, 2020
  59. refactor: Use member initializers in CCheckQueue 0ef938685b
  60. Add local thread pool to CCheckQueue 01511776ac
  61. test: Use CCheckQueue local thread pool dba30695fc
  62. bench: Use CCheckQueue local thread pool 6784ac471b
  63. refactor: Drop boost::thread stuff in CCheckQueue bb6fcc75d1
  64. refactor: Make CCheckQueue RAII-styled
    Also this commits gets rid of scriptcheckqueue global variable.
    8e78a419bf
  65. refactor: Drop g_parallel_script_checks global 56d40da18f
  66. hebasto force-pushed on Sep 24, 2020
  67. hebasto commented at 4:00 AM on September 24, 2020: member

    Rebased e5a82deda64a11f03c48a6fcaadb78ec3502745f -> 56d40da18fb60641c6dd683f77837cd32c0e24dd (pr18731.14 -> pr18731.15) due to the conflict with #19927.

  68. DrahtBot removed the label Needs rebase on Sep 24, 2020
  69. DrahtBot added the label Needs rebase on Dec 9, 2020
  70. DrahtBot commented at 11:14 AM on December 9, 2020: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    <sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

  71. hebasto marked this as a draft on Dec 19, 2020
  72. DrahtBot commented at 11:21 AM on December 15, 2021: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  73. DrahtBot commented at 1:07 PM on March 21, 2022: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  74. jonatack commented at 1:18 PM on March 21, 2022: contributor

    #18710 was merged, so this could be rebased and brought out of draft if you are still working on this.

  75. hebasto commented at 2:31 PM on April 22, 2022: member

    I won't be able to focus on this stuff in the near future.

    So closing up for grabs.

  76. hebasto closed this on Apr 22, 2022
  77. hebasto added the label Up for grabs on Apr 22, 2022
  78. hebasto commented at 1:18 PM on December 28, 2022: member

    I won't be able to focus on this stuff in the near future.

    So closing up for grabs.

    #26762.

  79. hebasto removed the label Up for grabs on Dec 28, 2022
  80. hebasto deleted the branch on Dec 28, 2022
  81. achow101 referenced this in commit 498994b6f5 on Nov 30, 2023
  82. bitcoin locked this on Dec 28, 2023
Contributors
hebastoDrahtBotpromagjonatack
Labels
RefactoringNeeds rebase
Linked (view graph)
#18710 Add local thread pool to CCheckQueue#26762 bugfix: Make `CCheckQueue` RAII-styled (attempt 2)
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me