test: Fix wallet_bumpfee intermittent error #18765

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-qaWalletBumpInterm changing 1 files +14 −10

MarcoFalke commented at 5:10 PM on April 25, 2020: member

Remove incorrect and undocumented connect_nodes(self.nodes[0], 1).

Issue is that transactions are re-relayed (going full circle) between the two nodes, that have two connections between each other.

https://travis-ci.org/github/bitcoin/bitcoin/jobs/679201559#L6992

Also fix some pep8 while touching the file

This bug has been introduced by accident in c1dde3a949b36ce9c2155777b3fa1372e7ed97d8
MarcoFalke force-pushed on Apr 25, 2020
DrahtBot added the label Tests on Apr 25, 2020
DrahtBot commented at 11:14 PM on April 27, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18788 (wallet: tests: Update more tests to work with descriptor wallets by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 1:13 PM on April 28, 2020: member

cc @achow101 This was accidentally introduced by you, so you seem qualified to review :grimacing:
achow101 commented at 3:44 PM on April 28, 2020: member

The self.sync_all() immediately following can be removed too.
test: Fix wallet_bumpfee intermittent error fa301fec96
MarcoFalke force-pushed on Apr 28, 2020
MarcoFalke commented at 3:53 PM on April 28, 2020: member

Thanks, fixed.
achow101 commented at 4:02 PM on April 28, 2020: member

ACK fa301fec966b77c54d02ac54ae7d726629adbfd5
MarcoFalke merged this on Apr 28, 2020
MarcoFalke closed this on Apr 28, 2020
MarcoFalke deleted the branch on Apr 28, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

test: Fix wallet_bumpfee intermittent error #18765

Conflicts