There are two equal ifs, one inside another. If the first one is true, then the second one is true.
As the code was before, toHTML added empty elements to mapValue to check for their existance. Now first it check for their existance and then for their non-emptiness.
This is the second try... The first time git ate my homework :-)
As the code was before, toHTML added empty elements to mapValue to check for their existance. Now first it check for their existance and then for their non-emptiness.
Removed a duplicated identical if
There are two equal ifs, one inside another. If the first one is true, then the second one is true.
ACK, I suppose this is a good start.
Ideally, toHTML should take a const CWalletTx &wtx to prevent it from making any change. The current state is lazyness from my side, I just copied toHTML from Satoshi's UI code.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/50e01ee620458a7204c234697efeab1c137018b9 for binaries and test log.