test: Check header hash in wait_for_getheaders #18838

1. 
   Nishikoh commented at 5:24 am on May 1, 2020: none

   Previously, wait_for_getheaders only looked for the presence of a recent "getheaders" message. Additionally checking the hashstop inside the message should make tests involving wait_for_getheaders more robust.

   Issue: #18614

2. fanquake added the label Tests on May 1, 2020
3. 
   DrahtBot commented at 10:17 am on May 1, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19489 (test: Fail wait_until early if connection is lost by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Needs rebase on May 20, 2020
5. rebase and fix conflict 35197243bc
6. DrahtBot removed the label Needs rebase on May 21, 2020
7. 
   Nishikoh commented at 7:44 am on May 21, 2020: none

   Rebased.
8. DrahtBot added the label Needs rebase on Aug 4, 2020
9. 
   DrahtBot commented at 11:08 am on August 4, 2020: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

10. 
    robot-dreams commented at 0:35 am on January 5, 2021: contributor

    Thanks for working on this!

    Yes, I agree that hash_stop is something we might consider checking. However, I’m worried that because most of the time calls to getheaders pass a hash_stop value of 0 (to indicate “get as many blocks as possible”) rather than a specific block’s hash value, replacing the existing logic with a hash_stop check might not actually make the tests more robust.

    What do you think?

11. 
    adamjonas commented at 5:10 pm on February 5, 2021: member

    Hi @Nishikoh - would you mind replying to robot-dream’s comment as well as rebasing this?
12. Nishikoh closed this on Jun 18, 2021

    ---

13. DrahtBot locked this on Aug 18, 2022

Contributors
Nishikoh DrahtBot robot-dreams adamjonas

Labels
Tests Needs rebase