test: Check header hash in wait_for_getheaders #18838

pull Nishikoh wants to merge 1 commits into bitcoin:master from Nishikoh:fix-wait_for_getheaders changing 5 files +13 −13

Nishikoh commented at 5:24 AM on May 1, 2020: none

Previously, wait_for_getheaders only looked for the presence of a recent "getheaders" message. Additionally checking the hashstop inside the message should make tests involving wait_for_getheaders more robust.

Issue: #18614
fanquake added the label Tests on May 1, 2020
DrahtBot commented at 10:17 AM on May 1, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19489 (test: Fail wait_until early if connection is lost by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Needs rebase on May 20, 2020
rebase and fix conflict 35197243bc
DrahtBot removed the label Needs rebase on May 21, 2020
Nishikoh commented at 7:44 AM on May 21, 2020: none

Rebased.
DrahtBot added the label Needs rebase on Aug 4, 2020
DrahtBot commented at 11:08 AM on August 4, 2020: member



🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
robot-dreams commented at 12:35 AM on January 5, 2021: contributor

Thanks for working on this!

Yes, I agree that hash_stop is something we might consider checking. However, I'm worried that because most of the time calls to getheaders pass a hash_stop value of 0 (to indicate "get as many blocks as possible") rather than a specific block's hash value, replacing the existing logic with a hash_stop check might not actually make the tests more robust.

What do you think?
adamjonas commented at 5:10 PM on February 5, 2021: member

Hi @Nishikoh - would you mind replying to robot-dream's comment as well as rebasing this?
Nishikoh closed this on Jun 18, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#18614 test: Check hash in wait_for_get* helpers

test: Check header hash in wait_for_getheaders #18838

Conflicts