Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 #18864

pull Sjors wants to merge 3 commits into bitcoin:master from Sjors:2020/05/backwards_compat changing 4 files +43 −15

Sjors commented at 11:41 AM on May 4, 2020: member

Thanks to #18774's adjust_bitcoin_conf_for_pre_17 we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet.

This PR bumps v0.19.0.1 to v0.19.1.

I also made the version list consistent for the contrib/devtools/previous_release.sh instruction, between both tests.
[test] add v0.16.3 backwards compatibility test 89a28e02fa
[test] backwards compatibility: bump v0.19.0.1 to v0.19.1 9c246b873c
fanquake added the label Tests on May 4, 2020

in ci/test/05_before_script.sh:40 in 9c246b873c outdated

  36 | @@ -37,6 +37,6 @@ if [ -z "$NO_DEPENDS" ]; then
  37 |  fi
  38 |  if [ "$TEST_PREVIOUS_RELEASES" = "true" ]; then
  39 |    BEGIN_FOLD previous-versions
  40 | -  DOCKER_EXEC contrib/devtools/previous_release.sh -b -t "$PREVIOUS_RELEASES_DIR" v0.15.2 v0.16.3 v0.17.1 v0.18.1 v0.19.0.1
  41 | +  DOCKER_EXEC contrib/devtools/previous_release.sh -b -t "$PREVIOUS_RELEASES_DIR" v0.15.2 v0.16.3 v0.17.1 v0.18.1 v0.19.1

MarcoFalke commented at 11:53 AM on May 4, 2020:

  DOCKER_EXEC contrib/devtools/previous_release.sh -b -t "$PREVIOUS_RELEASES_DIR" "${PREVIOUS_RELEASES_TO_DOWNLOAD}"

Can this be made a setting in the ci/test/00_* config files instead of an inline configuration?

(just a nit)

Sjors commented at 1:41 PM on May 4, 2020:

Will push a commit with that once the current Travis run finishes.

MarcoFalke approved
in ci/test/05_before_script.sh:38 in 9226c72364 outdated
```
  36 | @@ -37,6 +37,6 @@ if [ -z "$NO_DEPENDS" ]; then
  37 |  fi
  38 |  if [ "$TEST_PREVIOUS_RELEASES" = "true" ]; then
```
MarcoFalke commented at 7:05 PM on May 4, 2020:

if [ -n "$PREVIOUS_RELEASES_TO_DOWNLOAD" ]; then

nit in 9226c7236496ae92bfb472470c65b95caa95ed55, because TEST_PREVIOUS_RELEASES is primarily used to force the test of previous releases in the test framework (and fail if not available)
Sjors commented at 7:27 PM on May 4, 2020:

Done
MarcoFalke approved
MarcoFalke commented at 7:05 PM on May 4, 2020: member

ACK 9226c7236496ae92bfb472470c65b95caa95ed55
Sjors force-pushed on May 4, 2020
MarcoFalke commented at 10:44 PM on May 4, 2020: member

ACK 94d57bd2917a5c9111bd21ac27b829a25ed05fee

in ci/test/00_setup_env.sh:57 in 94d57bd291 outdated

  53 | @@ -54,6 +54,7 @@ export BASE_OUTDIR=${BASE_OUTDIR:-$BASE_SCRATCH_DIR/out/$HOST}
  54 |  # Folder where the build is done (dist and out-of-tree build).
  55 |  export BASE_BUILD_DIR=${BASE_BUILD_DIR:-$BASE_SCRATCH_DIR/build}
  56 |  export PREVIOUS_RELEASES_DIR=${PREVIOUS_RELEASES_DIR:-$BASE_ROOT_DIR/releases/$HOST}
  57 | +export PREVIOUS_RELEASES_TO_DOWNLOAD="v0.15.2 v0.16.3 v0.17.1 v0.18.1 v0.19.1"

MarcoFalke commented at 1:06 PM on May 7, 2020:

Oh, please only put this in the config that actually needs the releases

Sjors commented at 1:42 PM on May 8, 2020:

Good point

[ci] make list of previous releases to download a setting
Co-Authored-By: MarcoFalke <falke.marco@gmail.com>
d135c29476
Sjors force-pushed on May 8, 2020
MarcoFalke commented at 3:19 PM on May 8, 2020: member

ACK d135c294764add81683ba47575f9a5dde7d7c07f
MarcoFalke merged this on May 8, 2020
MarcoFalke closed this on May 8, 2020
Sjors deleted the branch on May 8, 2020
sidhujag referenced this in commit 52118221d4 on May 12, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Sjors

MarcoFalke

Labels

Tests

Linked (view graph)

#18774 test: added test for upgradewallet RPC