fix -Wformat warnings all over the source #1892

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2012_09_fixwformat changing 15 files +49 −39

laanwj commented at 12:49 PM on September 30, 2012: member

Fixes all format warnings and re-enables the warning messages.

replaces #1885
gavinandresen commented at 3:25 PM on October 1, 2012: contributor

Compiling on my Mac with llvm-g++, I get one warning:

main.cpp: In function ‘bool ProcessMessages(CNode*)’: main.cpp:3075: warning: format ‘%zu’ expects type ‘size_t’, but argument 2 has type ‘ptrdiff_t’
BitcoinPullTester commented at 4:51 PM on October 1, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4f8d9108b4d9a102aa1e1fd6fd916e339d6febc7 for binaries and test log.
Extend printf warnings to error() bcc292b22d
fix -Wformat warnings all over the source d210f4f5b8

Revert "Remove -Wformat* warnings from makefiles"

This reverts commit 14ac0adcc7c0224a467e38bbd4ebf39d824ada8d.

827d8c2e0c

laanwj commented at 5:47 PM on October 1, 2012: member

Thanks, seems that we also need a separate format for "ptrdiff_t". Should be fixed now.
gavinandresen merged this on Oct 1, 2012
gavinandresen closed this on Oct 1, 2012
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors