refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg #18937

1. 
   theStack commented at 5:55 pm on May 10, 2020: member

   Follow-up PR for #18533 – another small step towards getting rid of the confusing “command” terminology. Also see PR #18610 which tackled the functional tests.
2. in src/net.h:111 in 4f7b60e69d outdated

   107@@ -108,7 +108,7 @@ struct CSerializedNetMsg
   108     CSerializedNetMsg& operator=(const CSerializedNetMsg&) = delete;
   109 
   110     std::vector<unsigned char> data;
   111-    std::string command;
   112+    std::string msg_type;
   

   ---

   ---

   

   MarcoFalke commented at 6:21 pm on May 10, 2020:

   0    std::string m_type;
   

   According to the dev notes, members should be prefixed with m_.

   ---

   

   theStack commented at 6:53 pm on May 10, 2020:

   Thanks, done.
3. theStack force-pushed on May 10, 2020
4. DrahtBot added the label P2P on May 10, 2020
5. DrahtBot added the label Refactoring on May 10, 2020
6. refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg 51e9393c1f
7. theStack force-pushed on May 10, 2020
8. 
   MarcoFalke commented at 10:25 pm on May 13, 2020: member

   ACK 51e9393c1f6c9eaac554f821f5327f63bd09c8cf
9. 
   DrahtBot commented at 8:15 pm on May 20, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19031 (Implement ADDRv2 support (part of BIP155) by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. MarcoFalke merged this on Jun 19, 2020
11. MarcoFalke closed this on Jun 19, 2020

    ---

12. 
    jonatack commented at 11:01 am on June 19, 2020: member

    Concept ACK, msg_type is better
13. sidhujag referenced this in commit c47c194b1a on Jul 7, 2020
14. jasonbcox referenced this in commit 0b1e6312a7 on Nov 19, 2020
15. theStack deleted the branch on Dec 1, 2020
16. MarcoFalke referenced this in commit 973c390298 on Jan 24, 2022
17. sidhujag referenced this in commit b135edda87 on Jan 28, 2022
18. DrahtBot locked this on Feb 15, 2022

Contributors
theStack MarcoFalke DrahtBot jonatack

Labels
Refactoring P2P