What is the minimum supported version of boost for 0.21.0? #18943

1. 
   MarcoFalke commented at 11:30 am on May 11, 2020: member

   The wallet code uses Optional::emplace(), which was only added in boost 1.56, see https://github.com/boostorg/optional/commit/2e583aaf30964afd66c1284aa71d0d8b42fa440d

   So for 0.21.0 there are two options:

   • Work around emplace and keep the minimum boost version below 1.56
   • Require boost 1.56

   0wallet/rpcwallet.cpp: In function ‘UniValue listsinceblock(const JSONRPCRequest&)’:
   1wallet/rpcwallet.cpp:1560:16: error: ‘Optional<int>’ has no member named ‘emplace’
   2         height.emplace();
   3                ^
   4wallet/rpcwallet.cpp:1561:19: error: ‘Optional<int>’ has no member named ‘emplace’
   5         altheight.emplace();
   6                   ^
   

2. MarcoFalke added the label Bug on May 11, 2020
3. MarcoFalke added this to the milestone 0.21.0 on May 11, 2020
4. MarcoFalke referenced this in commit fa182a8794 on May 11, 2020
5. 
   MarcoFalke commented at 2:03 pm on May 11, 2020: member

   In the context of #16381 I think it is not worth to bump boost
6. laanwj closed this on May 14, 2020

   ---

7. sidhujag referenced this in commit 81b853d60d on May 17, 2020
8. janus referenced this in commit 59a8400441 on Nov 15, 2020
9. deadalnix referenced this in commit 430c7599fc on Jan 29, 2021
10. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke

Labels
Bug

Milestone
0.21.0