build: Ensure source tarball has leading directory name (0.20) #18945

1. 
   laanwj commented at 1:11 PM on May 11, 2020: member

   In the interest of moving 0.20.0 forward and being able to do rc2, extract and backport the non-controversial part from #18818.: ensure that the source tarball has leading directory name.

2. build: Ensure source tarball has leading directory name 59d57f6c10
3. laanwj added the label Build system on May 11, 2020
4. laanwj added this to the milestone 0.20.0 on May 11, 2020
5. laanwj added the label Needs gitian build on May 11, 2020
6. laanwj renamed this:
   build: Ensure source tarball has leading directory name
   build: Ensure source tarball has leading directory name (0.20)
   on May 11, 2020
7. 
   MarcoFalke commented at 1:25 PM on May 11, 2020: member

   I think DrahtBot can't build non-master branches, sorry :sweat_smile:

   Maybe @jonasschnelli's build farm can do?

8. hebasto approved
9. 
   hebasto commented at 3:07 PM on May 11, 2020: member

   ACK 59d57f6c103100b3fdef59298d57ee8cf4c0b181.

   FWIW, #18909 is also in progress.

10. laanwj removed the label Needs gitian build on May 11, 2020
11. 
    laanwj commented at 3:21 PM on May 11, 2020: member

    I think DrahtBot can't build non-master branches, sorry sweat_smile

    I'll try to run my own gitian build.

    FWIW, #18909 is also in progress.

    Yes, thank you. The reason to open this is that it's a) trivial b) everyone wants this c) I don't particularly want to hold up 0.20.0 on people agreeing whether to include the automake cruft or not.

12. 
    laanwj commented at 4:33 PM on May 11, 2020: member

    Gitian output:

    68a0a4f4728f23985ef937e38622e847fa9f1cae9e25ca8cf75a57cb7d908ffe  src/bitcoin-0.20.0rc1.tar.gz
    

    $ tar -tvf build/out/src/bitcoin-0.20.0rc1.tar.gz |less
    drwxrwxr-x root/root         0 2020-05-11 15:09 bitcoin-0.20.0rc1/
    -rw-rw-r-- root/root      4692 2020-05-11 15:09 bitcoin-0.20.0rc1/.appveyor.yml
    …
    

13. 
    Sjors commented at 5:32 PM on May 11, 2020: member

    tACK 59d57f6c103100b3fdef59298d57ee8cf4c0b181

    68a0a4f4728f23985ef937e38622e847fa9f1cae9e25ca8cf75a57cb7d908ffe  src/bitcoin-0.20.0rc1.tar.gz
    

    This extracts to bitcoin-0.20.0rc1 dir, presumably because it's based on the 0.20 branch?

14. 
    laanwj commented at 2:08 PM on May 12, 2020: member

    Yes, this is a fix for 0.20.0, it's supposed to do that.

    We should do a similar thing on master, but the gitian descriptors have been reorganized there (so the solution needs to be slightly different) and there's not as much hurry.

15. laanwj merged this on May 12, 2020
16. laanwj closed this on May 12, 2020

    ---

17. laanwj referenced this in commit f70eb51b05 on Nov 9, 2020
18. sidhujag referenced this in commit a59fbc36ff on Nov 9, 2020
19. UdjinM6 referenced this in commit 5242773943 on Oct 23, 2021
20. UdjinM6 referenced this in commit 94bf922354 on Oct 23, 2021
21. UdjinM6 referenced this in commit 09199e8415 on Dec 4, 2021
22. DrahtBot locked this on Feb 15, 2022

Contributors

laanwjMarcoFalkehebastoSjors

Milestone
0.20.0