RPC gettransaction() wrong sending address on internal transaction #18951

<!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

<!-- Describe the issue -->

Expected behavior The correct sending address in the transaction.

<!--- What behavior did you expect? -->

Actual behavior I made a transaction between 2 address in my wallet and then checked it with the gettransaction() function and the txid. It reported that the receiving address also sent the coins.

I can see in the testnet block explorer that transaction did in fact happen correctly. https://live.blockcypher.com/btc-testnet/tx/37e37cb8add45cc234f0d8f530ddd1346404be5da14a4ce125748dd13094aaea/

I sent from tb1qutv5a8vxthm6rqgfjexzvz3p49fyls74hj4zzu -> tb1q0yempvk7fwqz2k9j6utkkkuyt7fqznqjwplkhu

but the gettransaction() function is reporting this: https://i.imgur.com/TwiYPiC.png tb1q0yempvk7fwqz2k9j6utkkkuyt7fqznqjwplkhu -> tb1q0yempvk7fwqz2k9j6utkkkuyt7fqznqjwplkhu

<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

To reproduce Make an internal transaction and put the txid into this: https://gist.github.com/Nex4rius/47f4c2959d1d29cf51bac6bd4054d323

<!--- How reliably can you reproduce the issue, what are the steps to do so? -->

System information

<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

Bitcoin Core Version v0.19.0.1 (64-Bit)

<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

Window 10

<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->

<!-- Any extra information that might be useful in the debugging process. -->

<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

I've noticed that this also affects the listtransactions() function.

The receiving address (tb1q0) and the destination where the funds were sent to previously (tb1qu) are both controlled by your wallet, so it correctly tells you that this transaction involved a send as well as a receive.

That's not what I mean. I know that it has a send aswell as a receive.

Both the send and receive address are shown to be (tb1q0) but the sending address is in reality (tb1qu).

The (tb1qu) address isnt mention at all in this transaction from gettransaction(). (as shown in the imgur link)

There is no "send address" or "from address"

https://en.bitcoin.it/wiki/From_address

Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. Keep in mind that general bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange or the #bitcoin IRC channel on freenode.