gui: remove assert in walletcontroller & run setparent in gui-qt main thread #18961

 140 | +    if (QThread::currentThread() == thread()) {
 141 | +        addWallet(wallet_model);
 142 | +    } else {
 143 | +        // Handler callback runs in a different thread so fix wallet model thread affinity.
 144 | +        wallet_model->moveToThread(thread());
 145 | +        bool invoked = QMetaObject::invokeMethod(this, "addWallet", Qt::QueuedConnection, Q_ARG(WalletModel*, wallet_model));

promag commented at 11:27 PM on May 12, 2020:

I was going to suggest to use Qt::BlockingQueuedConnection instead, so that the caller gets the wallet model with the parent already set.

tarboss commented at 7:52 PM on May 13, 2020:

i think - it stucks on windows if u do Blocking. Need to check more, but not today.

 107 | @@ -108,9 +108,7 @@ WalletModel* WalletController::getOrCreateWallet(std::unique_ptr<interfaces::Wal
 108 |  
 109 |      // Instantiate model and register it.
 110 |      WalletModel* wallet_model = new WalletModel(std::move(wallet), m_client_model, m_platform_style, nullptr);
 111 | -    // Handler callback runs in a different thread so fix wallet model thread affinity.
 112 | -    wallet_model->moveToThread(thread());
 113 | -    wallet_model->setParent(this);
 114 | +

promag commented at 11:28 PM on May 12, 2020:

nit, remove (IMO).

 148 |      return wallet_model;
 149 |  }
 150 |  
 151 | +void WalletController::addWallet(WalletModel* wallet_model)
 152 | +{
 153 | +    // Take ownership of the wallet model and register it.

promag commented at 11:32 PM on May 12, 2020:

s/register/notify?

tarboss commented at 6:03 AM on May 13, 2020:

comment must be updated,too (setparent & emit to update gui), ownership already done in if-clause and register was in m_wallets.push_back(wallet_model) - if u change more in walletcontroller.cpp, u should change it.