For 0.22 we should look into enabling the warning again, which has been disabled in #18738
build: [0.22] Enable -Wdeprecated-copy warnings #18967
issue MarcoFalke opened this issue on May 13, 2020-
MarcoFalke commented at 1:26 PM on May 13, 2020: member
- MarcoFalke added the label Feature on May 13, 2020
- MarcoFalke added the label Build system on May 13, 2020
- MarcoFalke added this to the milestone 0.22.0 on May 13, 2020
- furszy referenced this in commit f6b14ca9ef on Jan 21, 2021
-
laanwj commented at 10:41 AM on June 14, 2021: member
Is this still to be addressed before 22.0?
-
MarcoFalke commented at 1:52 PM on June 14, 2021: member
I haven't checked if Ubuntu fixed this in the meantime (looks like qt abandoned the backport), but maybe we can apply the warning only when suppress-external is set?
-
hebasto commented at 2:17 PM on June 14, 2021: member
... maybe we can apply the warning only when suppress-external is set?
Something like https://github.com/bitcoin/bitcoin/pull/21667/commits/ebe68bd4c5ca030ec601f9bd1e8ca20cf8d9356b?
- fanquake closed this on Jun 17, 2021
- sidhujag referenced this in commit f5c50bd5c7 on Jun 18, 2021
- PastaPastaPasta referenced this in commit 65d37d9565 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 9266377560 on Jun 28, 2021
- PastaPastaPasta referenced this in commit f409a32467 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 9c480d085e on Jul 1, 2021
- PastaPastaPasta referenced this in commit bfb552a06b on Jul 1, 2021
- PastaPastaPasta referenced this in commit 6b12d652bf on Sep 21, 2021
- DrahtBot locked this on Aug 18, 2022