test: Add {} to force default initialization #18976

1. 
   MarcoFalke commented at 4:43 pm on May 14, 2020: member

   This is needed to be able to compile with clang 3.8
2. test: Add {} to force default initialization fa02f2fc10
3. MarcoFalke added the label Needs backport (0.20) on May 14, 2020
4. MarcoFalke added the label Tests on May 14, 2020
5. MarcoFalke added this to the milestone 0.20.0 on May 14, 2020
6. 
   MarcoFalke commented at 4:54 pm on May 14, 2020: member

   Steps to test on xenial:

    0root@d911ea00680b:/bitcoin# clang --version
    1clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
    2Target: x86_64-pc-linux-gnu
    3Thread model: posix
    4InstalledDir: /usr/bin
    5root@d911ea00680b:/bitcoin# make 
    6Making all in src
    7make[1]: Entering directory '/bitcoin/src'
    8make[2]: Entering directory '/bitcoin/src'
    9make[3]: Entering directory '/bitcoin'
   10make[3]: Leaving directory '/bitcoin'
   11  CXX      test/test_test_bitcoin-validationinterface_tests.o
   12test/validationinterface_tests.cpp:26:36: error: default initialization of an object of const type 'const BlockValidationState' without a user-provided default constructor
   13        const BlockValidationState state_dummy;
   14                                   ^
   15                                              {}
   161 error generated.
   17Makefile:16809: recipe for target 'test/test_test_bitcoin-validationinterface_tests.o' failed
   18make[2]: *** [test/test_test_bitcoin-validationinterface_tests.o] Error 1
   19make[2]: Leaving directory '/bitcoin/src'
   20Makefile:17084: recipe for target 'all-recursive' failed
   21make[1]: *** [all-recursive] Error 1
   22make[1]: Leaving directory '/bitcoin/src'
   23Makefile:782: recipe for target 'all-recursive' failed
   24make: *** [all-recursive] Error 1
   

    0root@d911ea00680b:/bitcoin# git checkout fa02f2fc10fb33d49e3e31819f67f309ebf9aa38
    1Note: checking out 'fa02f2fc10fb33d49e3e31819f67f309ebf9aa38'.
    2
    3You are in 'detached HEAD' state. You can look around, make experimental
    4changes and commit them, and you can discard any commits you make in this
    5state without impacting any branches by performing another checkout.
    6
    7If you want to create a new branch to retain commits you create, you may
    8do so (now or later) by using -b with the checkout command again. Example:
    9
   10  git checkout -b <new-branch-name>
   11
   12HEAD is now at fa02f2f... test: Add {} to force default initialization
   13root@d911ea00680b:/bitcoin# 
   14root@d911ea00680b:/bitcoin# make 
   15Making all in src
   16make[1]: Entering directory '/bitcoin/src'
   17make[2]: Entering directory '/bitcoin/src'
   18make[3]: Entering directory '/bitcoin'
   19make[3]: Leaving directory '/bitcoin'
   20  CXX      libbitcoin_util_a-clientversion.o
   21  AR       libbitcoin_util.a
   22  CXXLD    bitcoind
   23  CXXLD    bitcoin-cli
   24  CXXLD    bitcoin-tx
   25  CXX      test/test_test_bitcoin-validationinterface_tests.o
   26  CXX      test/util/libtest_util_a-net.o
   

7. MarcoFalke closed this on May 14, 2020

   ---

8. MarcoFalke deleted the branch on May 14, 2020
9. fanquake removed the label Needs backport (0.20) on May 15, 2020
10. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke

Labels
Tests

Milestone
0.20.0