[DONTMERGE] Test ranked_index #18977

pull sipa wants to merge 1 commits into bitcoin:master from sipa:202005_try_ranked changing 3 files +75 −0
  1. sipa commented at 10:44 PM on May 14, 2020: member

    This is a simple test to see if boost multi_index's ranked_index works in Travis.

    Do not merge.

  2. sipa force-pushed on May 14, 2020
  3. sipa force-pushed on May 14, 2020
  4. sipa renamed this:
    Test ranked_index
    [DONTMERGE] Test ranked_index
    on May 14, 2020
  5. Test ranked_index 6a39a2619e
  6. sipa force-pushed on May 14, 2020
  7. sipa commented at 11:11 PM on May 14, 2020: member

    It seems Ubuntu 16.04 (xenial) only has boost 1.58.

  8. MarcoFalke commented at 11:12 PM on May 14, 2020: member
  9. DrahtBot added the label Build system on May 15, 2020
  10. DrahtBot added the label Tests on May 15, 2020
  11. laanwj commented at 7:01 AM on May 15, 2020: member

    Xenial's C++ compiler doesn't support C++17 (#16684) so we're going to get rid of build-time support for that anyhow. I wouldn't mind dropping it sooner if you really need this (for 0.21, I mean; backporting any of this to 0.20 is out of the question).

    (also even after the minimum bump, if people really insist on building on xenial, they can use the boost from depends which is 1.70)

  12. DrahtBot commented at 7:09 AM on May 15, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18740 (Remove g_rpc_node global by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  13. MarcoFalke commented at 10:09 AM on May 15, 2020: member

    xenial ships also with clang-8, so that should compile C++17 . But I agree that at this point we should be comfortable to tell people to use depends on xenial.

  14. MarcoFalke commented at 12:41 PM on May 15, 2020: member

    For reference, the OS version breakdown of the snap package is:

    • 45% bionic
    • 15% 19.10
    • 10% focal
    • 5% xenial
    • 5% linux mint
    • x% some other non-Ubuntu OSes
  15. sipa commented at 10:31 PM on May 17, 2020: member

    Thanks for the information everyone. This may end up being useful, but it seems there is a better solution that doesn't need this.

  16. sipa closed this on May 17, 2020

  17. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me