gui: Remove un-actionable TODO #18997

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2005-guiNoTodo changing 3 files +5 −14

MarcoFalke commented at 2:59 PM on May 17, 2020: member

With encryption turned on by default for all wallets in consideration (#18889), I believe that wallet decryption will not be implemented ever or at least any time soon. So remove that TODO comment for now. If deemed important, a brainstorming issue can be opened instead.

Also remove some TODOs in the RPC console, which I don't understand. Maybe the gui was meant to show the debug log interactively? In any case, if deemed important, this should be filed as a brainstorming feature request, so that trade-offs of different solutions can be discussed.
gui: Remove un-actionable TODO 4444dbf4d5
MarcoFalke added the label GUI on May 17, 2020
MarcoFalke added the label Refactoring on May 17, 2020
Viral approved
fanquake requested review from achow101 on May 21, 2020
achow101 approved
achow101 commented at 3:51 AM on May 21, 2020: member

ACK 4444dbf4d5047dd1c92973f7167a74a0779e61a3

I don't think we should implement wallet decryption.
MarcoFalke commented at 12:02 PM on May 21, 2020: member

@jonasschnelli Anything left to do here?
laanwj commented at 2:44 PM on May 21, 2020: member

Thanks. ACK 4444dbf4d5047dd1c92973f7167a74a0779e61a3
MarcoFalke merged this on May 21, 2020
MarcoFalke closed this on May 21, 2020
MarcoFalke deleted the branch on May 21, 2020
sidhujag referenced this in commit 30cd7e0406 on May 21, 2020
Fabcien referenced this in commit 05a6eadd06 on Feb 4, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18889 [RFC] Wallet: Store unencrypted keys as encrypted with a default or plaintext passphrase