jamesob
commented at 4:21 PM on May 20, 2020:
member
Concept ACK
At some point we may just consider enabling threadnames by default; I don't think there's any noticeable performance penalty, but I can bench to verify.
MarcoFalke force-pushed on May 20, 2020
DrahtBot added the label Tests on May 20, 2020
DrahtBot
commented at 7:01 PM on May 20, 2020:
member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#19064 (refactor: Cleanup thread ctor calls by hebasto)
#18925 (Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler by naumenkogs)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Needs rebase on May 21, 2020
init: Setup scheduler in tests and init in exactly the same wayfa4ea997b4
test: Set -logthreadnames in unit tests99993489da
MarcoFalke force-pushed on May 21, 2020
DrahtBot removed the label Needs rebase on May 21, 2020
laanwj added this to the "Blockers" column in a project
laanwj
commented at 2:54 PM on July 1, 2020:
member
I'm not convinced on enabling logging of thread names by default, though more convenient during development, I think it increases the size of the log entries and files for something not useful for most users. But for the tests it makes a lot of sense.
Also the unifying of how to create the scheduler thread makes sense. Though we need to move away from the boost thread group at some point.
ACK99993489da9bc003b823bcab10e5f5297b369431
laanwj merged this on Jul 1, 2020
laanwj closed this on Jul 1, 2020
MarcoFalke deleted the branch on Jul 1, 2020
laanwj removed this from the "Blockers" column in a project
sidhujag referenced this in commit 6c722d711b on Jul 8, 2020
Fabcien referenced this in commit 1121f6f391 on Feb 4, 2022
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me