For the GUI version... As stderr and stdout point to the bit bucket in Windows for windowed applications, users get no error message.
When datadir missing, show messagebox instead of printing error to stderr #1905
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_10_startup_gui_error changing 1 files +4 −1-
laanwj commented at 5:49 AM on October 4, 2012: member
-
Diapolo commented at 7:43 AM on October 4, 2012: none
Also a good idea, but the strings could be translatable?
-
laanwj commented at 9:14 AM on October 4, 2012: member
They can't. This check is done far before the translation system is initialized, as to support lang= in bitcoin.conf (which is in the data directory). The old message was also not translated, I've just put it in useful form for windows users.
-
Diapolo commented at 9:22 AM on October 4, 2012: none
Right, didn't have that in my mind! ACK then.
-
laanwj commented at 9:51 AM on October 4, 2012: member
We could eventually decide that
bitcoin.confcontains core options and not GUI options (as we store GUI settings in QSettings now it's kind of pointless), but all changes in ordering have to be considered really carefully to not break anything. -
laanwj commented at 10:01 AM on October 4, 2012: member
I've added a comment to make this clear.
-
When datadir missing, show messagebox instead of printing error to stderr 61fd72695f
- laanwj referenced this in commit a6be58d536 on Oct 5, 2012
- laanwj merged this on Oct 5, 2012
- laanwj closed this on Oct 5, 2012
-
BitcoinPullTester commented at 12:54 AM on October 6, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/61fd72695f291a7a083cdc8ba96bda971c19eb53 for binaries and test log.
- laanwj deleted the branch on Apr 9, 2014
- KolbyML referenced this in commit ea5f85e071 on Dec 5, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors