testmempoolaccept should return the fee #19057

1. 
   MarcoFalke commented at 8:54 pm on May 22, 2020: member

   When testing a transaction for mempool acceptance, the fee must be calculated anyway. Thus, with minimal complexity overhead, the testmempoolaccept RPC could return the fee to the user.

   Useful skills:

   Basic understanding of the mempool, the Bitcoin Core RPC interface, and the functional test framework.

   Want to work on this issue?

   The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

   You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. MarcoFalke added the label good first issue on May 22, 2020
3. 
   rajarshimaitra commented at 9:18 am on May 23, 2020: contributor

   This seems like graspable at my level. Willing to give this a try. questions: What fee should the RPC return? The fee of the transaction or the minimum threshold fee for acceptance?

   Whats the motivation behind returning fee?

4. 
   MarcoFalke commented at 11:19 am on May 23, 2020: member

   The motivation behind this is that any caller (wallet, rpc, …) may want to know the fee of the transaction. Either for sanity checks or for bookkeeping.
5. fanquake closed this on Sep 19, 2020

   ---

6. sidhujag referenced this in commit 4d146837e5 on Sep 20, 2020
7. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke rajarshimaitra

Labels
good first issue