test: Remove global wait_until from p2p_getdata #19060

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2005-testWaitUntilGetdata changing 2 files +9 −11
  1. MarcoFalke commented at 1:57 pm on May 23, 2020: member

    Using the global wait_until makes it impossible to adjust the timeout based on the hardware the test is running on.

    Fix that by using the mininode member function.

    So for example, ./test/functional/p2p_getdata.py --timeout-factor=0.04 gives a timeout of 2.4 seconds.

  2. test: pep-8 p2p_getdata.py fab47375fe
  3. test: Default mininode.wait_until timeout to 60s 999922baed
  4. fanquake added the label Tests on May 23, 2020
  5. test: Remove global wait_until from p2p_getdata fa80b4788b
  6. MarcoFalke force-pushed on May 23, 2020
  7. laanwj commented at 5:05 pm on May 26, 2020: member
    ACK fa80b4788bbe3ef00c5d767c0d89ba9809d8707c
  8. laanwj merged this on May 26, 2020
  9. laanwj closed this on May 26, 2020

  10. sidhujag referenced this in commit 378add48a8 on May 27, 2020
  11. MarcoFalke deleted the branch on May 27, 2020
  12. Fabcien referenced this in commit eebe1aaf72 on Feb 4, 2021
  13. DrahtBot locked this on Feb 15, 2022


MarcoFalke laanwj

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-01 13:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me