test: Replace gobal wait_until with mininode.wait_until #19080

1. 
   MarcoFalke commented at 2:31 pm on May 27, 2020: member

   Using the global wait_until makes it impossible to adjust the timeout based on the hardware the test is running on.

   This should be fixed by using the mininode member function.

   See fa80b4788bbe3ef00c5d767c0d89ba9809d8707c for an example patch on how to fix it.

   List of potential “offenders”:

   0$ git grep -l --extended-regexp  '(import)? wait_until($|,)'
   

   Useful skills:

   Basic Python3

   Want to work on this issue?

   The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

   You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. MarcoFalke added the label good first issue on May 27, 2020
3. 
   dboures commented at 4:31 am on May 28, 2020: none

   Hi, I am planning to work on this.
4. 
   MarcoFalke commented at 12:04 pm on August 15, 2020: member

   #19134 is closed and thus, this issue is up for grabs again
5. 
   decentclock commented at 10:19 pm on August 16, 2020: none

   I’ll work on this.
6. 
   slmtpz commented at 10:34 pm on August 16, 2020: contributor

   I can also pick this up.
7. 
   decentclock commented at 11:10 pm on August 16, 2020: none

   @slmtpz ok i leave this to you then!
8. slmtpz referenced this in commit 963c9ce09c on Aug 17, 2020
9. 
   slmtpz commented at 11:43 am on August 18, 2020: contributor

   @MarcoFalke @gzhao408 Hey guys! Just wanted to ping you about my PR which I believe covers the rest of “wait_until” usages, since you were the ones most involved in the previous closed PR.
10. slmtpz referenced this in commit c3e1a30741 on Aug 20, 2020
11. slmtpz referenced this in commit 7a66c78b4d on Aug 25, 2020
12. slmtpz referenced this in commit 72516bb94b on Aug 25, 2020
13. slmtpz referenced this in commit 92e578c759 on Aug 25, 2020
14. slmtpz referenced this in commit 662636e859 on Aug 25, 2020
15. slmtpz referenced this in commit c132bc3294 on Aug 25, 2020
16. slmtpz referenced this in commit 449a0f9cb3 on Aug 25, 2020
17. slmtpz referenced this in commit ef8a9174d4 on Aug 26, 2020
18. slmtpz referenced this in commit 1343c86c7c on Aug 26, 2020
19. MarcoFalke referenced this in commit 28f4e53e16 on Aug 27, 2020
20. MarcoFalke closed this on Aug 27, 2020

    ---

21. sidhujag referenced this in commit 6a9ac03311 on Aug 28, 2020
22. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke dboures decentclock slmtpz

Labels
good first issue