Write linter to check that commit messages have a new line before the body (or no body) #19091

issue MarcoFalke openend this issue on May 28, 2020
  1. MarcoFalke commented at 3:06 pm on May 28, 2020: member

    This comes up really often: #19082 (comment)

    This can be based on the other lint scripts in ./test/lint.

    Want to work on this issue?

    The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

    You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. MarcoFalke added the label good first issue on May 28, 2020
  3. za-kk commented at 12:48 pm on May 31, 2020: contributor
    I will take a look at working on this one 👍
  4. skmcontrib commented at 12:51 pm on May 31, 2020: none
    @MarcoFalke can I work on this? So the ask is to write a linter to check the commit message for 70 characters and ensure it has a newline?
  5. MarcoFalke commented at 1:06 pm on May 31, 2020: member
    No, 70 characters should not be a requirement. Also, it looks like @za-kk is already working on this issue.
  6. scorbajio commented at 1:26 pm on June 22, 2020: none
    I would like to work on this issue if @za-kk is not actively working on it.
  7. scorbajio referenced this in commit ef28c5e39d on Jul 3, 2020
  8. scorbajio referenced this in commit acc86bd57a on Jul 6, 2020
  9. scorbajio referenced this in commit 6e8feaa3af on Jul 8, 2020
  10. scorbajio referenced this in commit cf714e4b4b on Jul 10, 2020
  11. scorbajio referenced this in commit a62b825369 on Jul 12, 2020
  12. scorbajio referenced this in commit 284a969cc0 on Jul 15, 2020
  13. MarcoFalke referenced this in commit edec7f7c25 on Jul 30, 2020
  14. yahiheb commented at 3:48 pm on July 30, 2020: contributor
    Should be closed since #19439 was merged.
  15. MarcoFalke closed this on Jul 30, 2020

  16. sidhujag referenced this in commit 0cd09e57ad on Jul 31, 2020
  17. Warchant referenced this in commit 5f60e2c41c on Aug 6, 2020
  18. PastaPastaPasta referenced this in commit f915d88046 on Jun 27, 2021
  19. PastaPastaPasta referenced this in commit a867a7fc74 on Jun 28, 2021
  20. PastaPastaPasta referenced this in commit ec0bc05cc4 on Jun 29, 2021
  21. PastaPastaPasta referenced this in commit 110cc8e9fe on Jul 1, 2021
  22. PastaPastaPasta referenced this in commit fd4513868b on Jul 1, 2021
  23. PastaPastaPasta referenced this in commit 4e07a366c2 on Jul 15, 2021
  24. PastaPastaPasta referenced this in commit 7a92af887d on Jul 16, 2021
  25. MarcoFalke locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me