qt: Add missing QPainterPath include #19097

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:qpainterpath-include changing 1 files +1 −0
  1. achow101 commented at 6:58 pm on May 28, 2020: member
    This is needed to compile with Qt 5.15.
  2. Add missing QPainterPath include
    This is needed to compile with Qt 5.15.
    79b0a69e09
  3. DrahtBot added the label GUI on May 28, 2020
  4. laanwj commented at 8:08 pm on May 28, 2020: member
    Code review ACK 79b0a69e09c1a912122e6431ea3c530cc292c690
  5. MarcoFalke commented at 8:14 pm on May 28, 2020: member
    Code review ACK 79b0a69
  6. promag commented at 9:18 pm on May 28, 2020: member

    Code review ACK 79b0a69e09c1a912122e6431ea3c530cc292c690.

    nit, could also forward declare in src/qt/trafficgraphwidget.h.

  7. fanquake merged this on May 29, 2020
  8. fanquake closed this on May 29, 2020

  9. fanquake deleted a comment on May 29, 2020
  10. fanquake added the label Needs backport (0.20) on May 29, 2020
  11. fanquake added this to the milestone 0.20.1 on May 29, 2020
  12. puchu commented at 9:48 pm on June 2, 2020: contributor

    Code review ACK 79b0a69.

    nit, could also forward declare in src/qt/trafficgraphwidget.h.

    should be in the h file as it’s already used there

  13. promag commented at 9:52 pm on June 2, 2020: member
    Definition isn’t necessary in the header, forward declaration is enough.
  14. puchu commented at 10:00 pm on June 2, 2020: contributor

    but what’s the benefit, instead of directly including it in the h file?

    would actually save one line of code ;)

  15. promag commented at 10:05 pm on June 2, 2020: member
    It’s usually best practice to just include an header when the definition is required to minimize the compiler work.
  16. puchu commented at 10:18 pm on June 2, 2020: contributor
    makes sense
  17. luke-jr referenced this in commit 384d3f991c on Jun 4, 2020
  18. MarcoFalke referenced this in commit cd32134bda on Jun 4, 2020
  19. MarcoFalke removed the label Needs backport (0.20) on Jun 4, 2020
  20. fanquake referenced this in commit b7e16a82c9 on Jul 15, 2020
  21. MarcoFalke referenced this in commit 28a9df7d76 on Aug 11, 2020
  22. Bushstar referenced this in commit e4ff5b1505 on Oct 21, 2020
  23. Platinumwrist referenced this in commit 05e2740d92 on Oct 25, 2020
  24. buzzkillb referenced this in commit c44ebe0ce2 on Dec 5, 2020
  25. blockstreamsatellite referenced this in commit 38fd49d98c on Jan 29, 2021
  26. backpacker69 referenced this in commit 7bb20aff8c on Mar 28, 2021
  27. PastaPastaPasta referenced this in commit 4f81faa0d2 on Jun 27, 2021
  28. PastaPastaPasta referenced this in commit d5ab2cb7d8 on Jun 28, 2021
  29. PastaPastaPasta referenced this in commit 73ea0c4d41 on Jun 29, 2021
  30. PastaPastaPasta referenced this in commit 44339c6b54 on Jul 1, 2021
  31. PastaPastaPasta referenced this in commit eba7d8a6ad on Jul 1, 2021
  32. PastaPastaPasta referenced this in commit 286290bc77 on Jul 14, 2021
  33. PastaPastaPasta referenced this in commit 68e1c05e8b on Jul 15, 2021
  34. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me