fix wrong (signed/unsigned) printf format specifier in bitcoinrpc.cpp #1911

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:fix_signed_unsigned changing 2 files +2 −2

Diapolo commented at 5:29 PM on October 5, 2012: none
- also includes the required bitcoinstrings.cpp update
gavinandresen commented at 6:01 PM on October 5, 2012: contributor

ACK. Will this break translations? So should it wait until after 0.7.1 ?
laanwj commented at 6:23 PM on October 5, 2012: member

Yes, this will break translations.

BTW how do you get signed/unsigned warnings for printf? Normally it only barks on data type width mismatches.
Diapolo commented at 7:41 PM on October 5, 2012: none

Yes the wording of the pull is misleading, it should read "fix wrong (signed/unsigned) printf format specifier in bitcoinrpc.cpp", sorry. Should be merged after 0.7.1.

Edit: Updated to clarify commit message!
fix wrong (signed/unsigned) printf format specifier in bitcoinrpc.cpp
- also includes the required bitcoinstrings.cpp update
95e625d235
jgarzik commented at 10:05 PM on October 8, 2012: contributor

ACK
laanwj referenced this in commit 089b10a28a on Oct 11, 2012
laanwj merged this on Oct 11, 2012
laanwj closed this on Oct 11, 2012
KolbyML referenced this in commit c9f16d09ad on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors