rpc: Remove special case for unknown service flags #19112

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2005-rpcServiceFlagsUnknown changing 2 files +11 −6

MarcoFalke commented at 10:06 PM on May 29, 2020: member

The special case to return a bit as an integer is clumsy and undocumented. Probably also irrelevant because there shouldn't currently be a non-misbehaving client that connects to Bitcoin Core and advertises an unknown service flag.

Thus, simply remove the code.
MarcoFalke added the label RPC/REST/ZMQ on May 29, 2020
MarcoFalke force-pushed on May 29, 2020
rpc: Remove special case for unknown service flags fa1433ac1b
MarcoFalke force-pushed on May 29, 2020
laanwj commented at 3:04 PM on June 4, 2020: member

ACK fa1433ac1be8481f08c1a0a311a6b87d8a874c6a I also had this as a comment in the PR on the code introducing this, but somehow it was never addressed.
laanwj merged this on Jun 4, 2020
laanwj closed this on Jun 4, 2020
MarcoFalke deleted the branch on Jun 4, 2020
sidhujag referenced this in commit 329fd2d640 on Jun 4, 2020
luke-jr commented at 4:56 PM on June 5, 2020: member

Postmerge utACK
jasonbcox referenced this in commit 386a4de52d on Nov 25, 2020
PastaPastaPasta referenced this in commit c59f1a20d8 on Dec 22, 2021
PastaPastaPasta referenced this in commit 52c3f0f155 on Dec 22, 2021
PastaPastaPasta referenced this in commit 8bae870848 on Dec 22, 2021
PastaPastaPasta referenced this in commit 94f98e38a0 on Dec 28, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels