- this extends the persistent tray icon until shutdown is complete, to ensure users wait before trying to restart the client
Qt: add an exit notification on client shutdown #1914
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_show_exit_notify changing 2 files +11 −1-
Diapolo commented at 4:31 PM on October 7, 2012: none
-
5805b5a844
Qt: add an exit notification on client shutdown
- this extends the persistent tray icon until shutdown is complete, to ensure users wait before trying to restart the client
-
laanwj commented at 6:09 PM on October 14, 2012: member
I agree that it could be useful to show that it's still doing something while shutting down, to prevent the user from shutting down his computer while it's busy.
However, I'm not sure a notification is the right thing to do here. After all, we can't reliably control how long it is shown.
-
Diapolo commented at 7:19 PM on October 14, 2012: none
Well it is shown as long as it takes to shutdown the client, which is a behaviour I like. When there is some DB work to do before we can shutdown, you clearly see the client is still working in the background. A quick shutdown means you just see this flash up and disappear.
Did you try / test the patch?
-
BitcoinPullTester commented at 6:27 AM on October 20, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5805b5a8447ea40ac30e92c895fd21ddace1e020 for binaries and test log.
-
sipa commented at 11:24 PM on October 28, 2012: member
I tried to test this, but shutdown is too quick to see anything. What should happen?
-
Diapolo commented at 6:35 AM on October 29, 2012: none
It should show a tray-notification (dunno how such a thing is called with Linux) as long as the client is shuting-down I found out, that after your Ultraprune-patch, the client is shuting down much more quickly than before, so perhaps this patch doesn't make sense anymore.
-
laanwj commented at 6:21 AM on October 31, 2012: member
The problem is that notification behavior is OS dependent. On some OSes it might show until the program terminates, on others it may be gone before that, and on still others it could linger after the program died.
-
Diapolo commented at 6:59 AM on October 31, 2012: none
I'll close this one, you are right.
- Diapolo closed this on Oct 31, 2012
- KolbyML referenced this in commit 017396d2aa on Dec 5, 2020
- DrahtBot locked this on Sep 8, 2021