include QPainterPath to fix compile error with Qt 5.15 #19144

puchu commented at 9:32 PM on June 2, 2020: contributor

include QPainterPath to fix compile error with Qt 5.15

include QPainterPath to fix compile error with Qt 5.15 d725859f77

puchu commented at 9:34 PM on June 2, 2020: contributor

compile error is:

qt/trafficgraphwidget.cpp: In member function ‘void TrafficGraphWidget::paintPath(QPainterPath&, QQueue<float>&)’:
qt/trafficgraphwidget.cpp:55:9: error: invalid use of incomplete type ‘class QPainterPath’
   55 |         path.moveTo(x, YMARGIN + h);
      |         ^~~~
In file included from /usr/include/qt5/QtGui/qbrush.h:49,
                 from /usr/include/qt5/QtGui/qpalette.h:46,
                 from /usr/include/qt5/QtWidgets/qwidget.h:48,
                 from /usr/include/qt5/QtWidgets/QWidget:1,
                 from ./qt/trafficgraphwidget.h:8,
                 from qt/trafficgraphwidget.cpp:6:
/usr/include/qt5/QtGui/qmatrix.h:54:7: note: forward declaration of ‘class QPainterPath’
   54 | class QPainterPath;
      |       ^~~~~~~~~~~~
qt/trafficgraphwidget.cpp:59:13: error: invalid use of incomplete type ‘class QPainterPath’
   59 |             path.lineTo(x, y);
      |             ^~~~
In file included from /usr/include/qt5/QtGui/qbrush.h:49,
                 from /usr/include/qt5/QtGui/qpalette.h:46,
                 from /usr/include/qt5/QtWidgets/qwidget.h:48,
                 from /usr/include/qt5/QtWidgets/QWidget:1,
                 from ./qt/trafficgraphwidget.h:8,
                 from qt/trafficgraphwidget.cpp:6:
/usr/include/qt5/QtGui/qmatrix.h:54:7: note: forward declaration of ‘class QPainterPath’
   54 | class QPainterPath;
      |       ^~~~~~~~~~~~
qt/trafficgraphwidget.cpp:61:9: error: invalid use of incomplete type ‘class QPainterPath’
   61 |         path.lineTo(x, YMARGIN + h);
      |         ^~~~
In file included from /usr/include/qt5/QtGui/qbrush.h:49,
                 from /usr/include/qt5/QtGui/qpalette.h:46,
                 from /usr/include/qt5/QtWidgets/qwidget.h:48,
                 from /usr/include/qt5/QtWidgets/QWidget:1,
                 from ./qt/trafficgraphwidget.h:8,
                 from qt/trafficgraphwidget.cpp:6:
/usr/include/qt5/QtGui/qmatrix.h:54:7: note: forward declaration of ‘class QPainterPath’
   54 | class QPainterPath;
      |       ^~~~~~~~~~~~
qt/trafficgraphwidget.cpp: In member function ‘virtual void TrafficGraphWidget::paintEvent(QPaintEvent*)’:
qt/trafficgraphwidget.cpp:109:22: error: aggregate ‘QPainterPath p’ has incomplete type and cannot be defined
  109 |         QPainterPath p;
      |                      ^
qt/trafficgraphwidget.cpp:116:22: error: aggregate ‘QPainterPath p’ has incomplete type and cannot be defined
  116 |         QPainterPath p;
      |                      ^

promag commented at 9:37 PM on June 2, 2020: member

You should backport #19097 instead.

puchu commented at 9:38 PM on June 2, 2020: contributor

thanks, i will give it a try. ;)

why wasn't this included in the 0.20 tag?

promag commented at 9:41 PM on June 2, 2020: member

Was set to 0.20.1 milestone.

MarcoFalke commented at 9:57 PM on June 2, 2020: member

This is part of the group that is tagged for backport: https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport+%280.20%29%22+

DrahtBot added the label GUI on Jun 2, 2020

laanwj commented at 3:09 PM on June 4, 2020: member

If you add the appropriate backporting metadata (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#backporting) and copy the author/commit message then you could turn this into a backport of #19097.

MarcoFalke closed this on Jun 4, 2020

promag commented at 10:36 PM on June 4, 2020: member

@puchu backport done in #19170.

DrahtBot locked this on Feb 15, 2022