sync: remove unneeded LockData::invlockorders #19158

pull vasild wants to merge 1 commits into bitcoin:master from vasild:remove_invlockorders changing 1 files +0 −11

vasild commented at 2:32 PM on June 3, 2020: member

Just LockData::lockorders suffices to perform the lock ordering checks.

sync: remove unneeded LockData::invlockorders

Just `LockData::lockorders` suffices to perform the lock ordering
checks.

d69a99ab0a

MarcoFalke commented at 2:43 PM on June 3, 2020: member

commit 5eeb913d6cff9cfe9a6769d7efe4a7b9f23de0f4 says:

Implement this clean up by remembering not only the pairs in forward direction,
but also backward direction. This allows for fast iteration over all pairs that
use a deleted CCriticalSection in either the first or the second position.

vasild commented at 6:47 PM on June 3, 2020: member

Doh! That's right - if we just remove invlockorders then when deleting a mutex it will remain in lockorders if it appears as a second mutex in some pair.

Thanks for digging that commit and sorry for the noise!
vasild closed this on Jun 3, 2020
vasild deleted the branch on Jun 3, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

vasild

MarcoFalke