Handle incompatible BDB environments #1917

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:BDB_DOWNGRADE changing 2 files +19 −15
  1. gavinandresen commented at 7:21 pm on October 8, 2012: contributor

    Before, opening a -datadir that was created with a new version of Berkeley DB would result in an un-caught DB_RUNRECOVERY exception.

    After these changes, the error is caught and the user is told that there is a problem and is told how to try to recover from it.

  2. jgarzik commented at 7:33 pm on October 8, 2012: contributor
    Seems sane, but incomplete: turning off exceptions implies you must run through the code, and replace all existing exception checks with return value checks. EnvShutDown is one obvious example, but there may be more that require converting, before exceptions are simply disabled.
  3. Handle incompatible BDB environments
    Before, opening a -datadir that was created with a new
    version of Berkeley DB would result in an un-caught DB_RUNRECOVERY
    exception.
    
    After these changes, the error is caught and the user is told
    that there is a problem and is told how to try to recover from
    it.
    e4954b1297
  4. gavinandresen commented at 7:53 pm on October 8, 2012: contributor
    EnvShutDown was the only place where exception error checking was expected. Everyplace else returns-error-code error handling was used.
  5. jgarzik commented at 8:02 pm on October 8, 2012: contributor
    ACK
  6. gavinandresen merged this on Oct 8, 2012
  7. gavinandresen closed this on Oct 8, 2012

  8. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me