build: turn on --enable-c++17 by --enable-fuzz #19173

pull vasild wants to merge 1 commits into bitcoin:master from vasild:enable_c++17_by_fuzz changing 4 files +7 −7

vasild commented at 9:54 AM on June 5, 2020: member

Fuzzing code uses C++17 specific code (e.g. std::optional), so it is not possible to compile with --enable-fuzz and without --enable-c++17.

Thus, turn on --enable-c++17 whenever --enable-fuzz is used.

build: turn on --enable-c++17 by --enable-fuzz

Fuzzing code uses C++17 specific code (e.g. std::optional), so it is not
possible to compile with --enable-fuzz and without --enable-c++17.

Thus, turn on --enable-c++17 whenever --enable-fuzz is used.

0012471391

fanquake added the label Build system on Jun 5, 2020
hebasto commented at 10:11 AM on June 5, 2020: member

Fuzzing code uses C++17 specific code...

Since when?
vasild commented at 10:26 AM on June 5, 2020: member

#18938 contains "Switch from Optional<T> to std::optional<T> (C++17)"

Also #18901 and #18939 are related.
hebasto approved
hebasto commented at 11:03 AM on June 5, 2020: member

ACK 00124713912ead4ce610d519bb3ebab7e31cbea7, tested on Linux Mint 19.3 (x86_64); verified that it fails to compile with --enable-fuzz and without --enable-c++17 on master.
MarcoFalke merged this on Jun 5, 2020
MarcoFalke closed this on Jun 5, 2020
MarcoFalke commented at 11:18 AM on June 5, 2020: member

Thanks
vasild deleted the branch on Jun 5, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels