refactor: Replace RecursiveMutex with Mutex in Shutdown() #19180

1. 
   hebasto commented at 7:10 pm on June 5, 2020: member

   Step by step, going to replace all of the RecursiveMutex instances with the Mutex ones throughout the code base :)

   Not sure if it is possible in all cases though…

   This one is a low-hanging fruit.

2. refactor: Replace RecursiveMutex with Mutex in Shutdown() 1a9ef1d398
3. fanquake added the label Refactoring on Jun 5, 2020
4. hebasto marked this as ready for review on Jun 5, 2020
5. 
   MarcoFalke commented at 8:09 pm on June 5, 2020: member

   ACK 1a9ef1d398dd14728b6bc67a89139cdf827c9753 Shutdown is not recursive, so the same thread can never lock twice (UB)
6. 
   DrahtBot commented at 1:02 am on June 6, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19192 (doc: Extract net permissions doc by MarcoFalke)
   • #19064 (refactor: Cleanup thread ctor calls by hebasto)
   • #18077 (net: Add NAT-PMP port forwarding support by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   vasild commented at 7:57 am on June 8, 2020: member

   ACK 1a9ef1d3 verified manually that Shutdown() is not called from places that could be called from inside Shutdown().

   Not sure if it is possible in all cases though…

   I think it should be

8. vasild approved
9. 
   hebasto commented at 8:38 am on June 8, 2020: member

   @sipa Mind reviewing this PR?
10. MarcoFalke merged this on Jun 8, 2020
11. MarcoFalke closed this on Jun 8, 2020

    ---

12. hebasto deleted the branch on Jun 8, 2020
13. MarcoFalke referenced this in commit 8496dbeba6 on Jun 8, 2020
14. MarcoFalke referenced this in commit 374fd6fc8b on Jun 8, 2020
15. MarcoFalke referenced this in commit 9ad6f14175 on Jun 9, 2020
16. Fabcien referenced this in commit c9c716200e on Mar 1, 2021
17. PastaPastaPasta referenced this in commit 40f173954b on Jun 27, 2021
18. PastaPastaPasta referenced this in commit 6c258b1f13 on Jun 28, 2021
19. PastaPastaPasta referenced this in commit b192adca4f on Jun 29, 2021
20. PastaPastaPasta referenced this in commit 7eb2b2f910 on Sep 17, 2021
21. PastaPastaPasta referenced this in commit 12b5cfcff0 on Sep 19, 2021
22. thelazier referenced this in commit d9423ace44 on Sep 25, 2021
23. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto MarcoFalke DrahtBot vasild

Labels
Refactoring