The close button of the command line options window doesn't work #1919

issue ghost opened this issue on October 10, 2012
  1. ghost commented at 10:57 AM on October 10, 2012: none

    The close button of the command line options window doesn't seem to work with Bitcoin-Qt 0.7.0 (and with a tarball from github I compiled a few days ago) on Ubuntu Lucid and Precise amd64. It simply has no effect at all. The issue is very easy to reproduce: just click Help > Debug Window > Command line options and you'll get the following window: Bitcoin command line options window

    Then try to close the button by clicking on the usual "X" button. Only the OK button closes that window.

    As as side remark, note that currently the "OK" and "Show/Hide Details" buttons do not seem to have i18n support. They are displayed in English with languages translated at 100% on Transifex. It may also be useful to give users the possibility to resize that window so that the listed options can be read more easily.

  2. Diapolo commented at 4:49 PM on October 10, 2012: none

    I tested this with official 0.7.0 release and on Windows 7 x64 the "X" button, is greyed out and not usable for me. The button text is untranslated, so that is an issue (see #1137 for more details as I've observed this before). You can see this, when clicking Settings > Encrypt Wallet..., the Cancel message is untranslated, too.

    Your suggestion to make that window resizable is nice, but such QDialogs don't allow to resize them :-/, sorry.

  3. laanwj commented at 6:01 PM on October 10, 2012: member

    This dialog is a quick hack to get around the limitation of stdout/stderr in windows programs, and never meant as more than that. It uses the default QMessageBox, as doing anything else would be bloat (we really don't want a custom view for this).

    I'm thinking of removing the button from the Debug dialog, as it makes people expect too much from it.

  4. Diapolo commented at 5:58 AM on October 11, 2012: none

    @laanwj It is rather clear what the button is intended for, I see no need to remove it, as it should be helpful at first for all Windows users, which are not that familiar with command-line fiddling ;).

  5. laanwj commented at 6:25 AM on October 11, 2012: member

    Yes it is clear what the button is for, however, making it part of the "main" UI seems to confuse people into thinking it should be all-polished.

    Maybe we should make it windows-only at least. For Linux, the way to get command line options is the good old 'bitcoin --help' (or the man page, if someone bothered to keep it up to date). You can pipe it into your own pager or text editor and resize the window as big as you want :-)

    I'm sorry for the effort you put into reporting this issue but I have to close this with "WONTFIX".

  6. laanwj closed this on Oct 11, 2012

  7. ghost commented at 8:22 PM on October 11, 2012: none

    I tested this with official 0.7.0 release and on Windows 7 x64 the "X" button, is greyed out and not usable for me.

    Probably a glitch with Qt on Unix-like systems side then. I was using GNOME 2.30.2 on Lucid and MATE 1.4 on Precise on which the screen shot was taken. Anyway, it's just window cosmetics so not a big deal, really.

    It is rather clear what the button is intended for, I see no need to remove it, as it should be helpful at first for all Windows users, which are not that familiar with command-line fiddling ;).

    +1. That's how once I learnt about command line options in general so IMHO it makes sense to keep it (on GNU/Linux too). Even more so as copying & pasting its content works fine. Sure, you'll get questions but some people will also learn about these options.

    I'm sorry for the effort you put into reporting this issue but I have to close this with "WONTFIX".

    In fact I thought devs had forgotten to polish that window so wanted to bring it to your attention, just in case. But no problem if Qt's limitations prevent that polishing: it's already good enough and helpful as it is, so thanks for replying and keep coding for us :p

  8. KolbyML referenced this in commit df2a6dbf60 on Dec 5, 2020
  9. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me