refactor: Replace RecursiveMutex with Mutex in netbase.cpp #19190

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200606-netbase changing 1 files +9 −9
  1. hebasto commented at 2:37 PM on June 6, 2020: member

    The functions that could lock this mutex, i.e., {S,G}etProxy(), {S,G}etNameProxy(), HaveNameProxy(), IsProxy(), do not call itself recursively, and do not call each other either directly or indirectly. Therefore, the g_proxyinfo_mutex could be a non-recursive mutex.

    Related to #19180.

  2. refactor: Replace RecursiveMutex with Mutex in netbase.cpp 78c8f4fe11
  3. fanquake added the label Refactoring on Jun 6, 2020
  4. MarcoFalke commented at 12:14 PM on June 7, 2020: member

    ACK 78c8f4fe11706cf5c165777c2ca122bd933b8b6a , reviewed with the -W git option 👮

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    ACK 78c8f4fe11706cf5c165777c2ca122bd933b8b6a , reviewed with the -W git option 👮
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    pUgFBQv/VKLV3VvVK0DdEJjxXBp86i56TsUbkbHOffHUz7PAQn1RCPkGfj8RVlIc
    bZINWaM0VcNyFSiFpYeixbFnvehiKTQ2yRQWqxUvGJo0KOufYf64vkYxjTvDiCCw
    BUHgvO8hOICjuqtARWhOEnkdNjCZKgwx2vg9ECMceqLSwAAwAHbZg/OU30wACxrw
    FI2pjW4gbTNNOuK+n3Ee0xkDk6OwiW3GYZhNsG+68GOfRnSIYsUp28Ap9EeE4C0v
    3NJPrrcYuXGfV+fV80OazLs6THVQVB+G7VMeV4fOcmOckqX20lk6ZCzRPVpNu1bY
    8qJ1Nk3ceSsmMw+urZPHPa/XP+rV+Wz010Rf/5ZVMuV6YNk5xU6CIvKT2h2L3II8
    2IvmDtBM47myml2hOZ9TdZtqqeEIh5Ccv0FxXn+vnttqC/4FyhIQ5Eb9BsmOYBVN
    1I3/kyBJigIXGEqeYOGYMyzqGHPY4TAC1U1gjL55TSUR7wLuK+rZgs+O4N4p2twm
    PKmdVZCE
    =BccQ
    -----END PGP SIGNATURE-----
    

    Timestamp of file with hash 06fffd333134ff9c5a8ca051f2718b74b487a29b57f0bad5082eee16ab655a12 -

    </details>

  5. vasild approved
  6. vasild commented at 8:35 AM on June 8, 2020: member

    ACK 78c8f4fe verified that recursion does not happen

  7. hebasto commented at 8:38 AM on June 8, 2020: member

    @sipa Mind reviewing this PR?

  8. MarcoFalke merged this on Jun 8, 2020
  9. MarcoFalke closed this on Jun 8, 2020

  10. hebasto deleted the branch on Jun 8, 2020
  11. Fabcien referenced this in commit fcdf7460ad on Mar 10, 2021
  12. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me