log: remove deprecated `db` log category #19202

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:remove-deprecated-db-log-category changing 2 files +4 −9

jonatack commented at 3:32 PM on June 7, 2020: member

The db log category was renamed to walletdb (like coindb) in #17410 and its upcoming removal announced in the 0.20 release notes.

- The `-debug=db` logging category has been renamed to
  `-debug=walletdb` to distinguish it from `coindb`.  The `-debug=db`
  option has been deprecated and will be removed in the next major
  release.  (#17410)

This PR removes the warning and reverts to the usual behavior for an unrecognised log category.

$ bitcoin-cli logging '["db"]'
error code: -8
error message:
unknown logging category db

$ ./src/bitcoind -debug=db
Warning: Unsupported logging category -debug=db.
2020-06-07T15:30:45Z Bitcoin Core version v0.20.99.0-4c0c89307d (debug build)
2020-06-07T15:30:45Z Warning: Unsupported logging category -debug=db.
2020-06-07T15:30:45Z Assuming ancestors of block 0000000000000000000f2adce67e49b0b6bdeb9de8b7c3d7e93b21e7fc1e819d have valid signatures.
2020-06-07T15:30:45Z Setting nMinimumChainWork=00000000000000000000000000000000000000000e1ab5ec9348e9f4b8eb8154
2020-06-07T15:30:45Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2020-06-07T15:30:45Z Using RdSeed as additional entropy source

log: remove deprecated `db` log category 4c0c89307d
in doc/release-notes-19202.md:4 in 5be0eefd2b outdated
```
   0 | @@ -0,0 +1,4 @@
   1 | +## Updated settings
   2 | +
   3 | +- The `-debug=db` logging category, which was deprecated in 0.20 and replaced by
   4 | +  `-debug=walletdb` to distinguish it from `coindb`, has been removed. (#19202)
```
MarcoFalke commented at 3:43 PM on June 7, 2020:

I wouldn't mind if this snippet was put straight into the release notes, as there shouldn't be any conflicts with this one. This would avoid having someone to touch it again to merge it in. Though, no big deal either way.

jonatack commented at 4:00 PM on June 7, 2020:

Done
MarcoFalke approved
MarcoFalke commented at 3:43 PM on June 7, 2020: member

ACK 5be0eefd2b5f510b2bbc9c683af6ee4985f2e50e
doc: release note for `db` log category removal c514a4f59a
jonatack force-pushed on Jun 7, 2020

MarcoFalke commented at 4:30 PM on June 7, 2020: member

ACK c514a4f59a7430f05dbe20465ddf4ca323329f1e 🔄

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash fadeaad1a61fbdcd101783f4c4ba375477573325e34d425e329563648f8c2d87 -

</details>

MarcoFalke merged this on Jun 7, 2020
MarcoFalke closed this on Jun 7, 2020
jonatack deleted the branch on Jun 7, 2020
laanwj commented at 12:05 PM on June 9, 2020: member

Posthumous ACK c514a4f59a7430f05dbe20465ddf4ca323329f1e
deadalnix referenced this in commit f7a31614ba on Oct 16, 2020
barton2526 referenced this in commit 928af9f743 on Jun 24, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

jonatack

MarcoFalke

laanwj

Linked (view graph)

#17410 Rename `db` log category to `walletdb` (like `coindb`)