refactor: Replace RecursiveMutex with Mutex in warnings.cpp #19220

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200609-warn-mx changing 1 files +9 −9
  1. hebasto commented at 6:42 AM on June 9, 2020: member

    The functions that could lock this mutex, i.e., SetMiscWarning(), {S,G}etfLargeWorkForkFound(), SetfLargeWorkInvalidChainFound(), GetWarnings(), do not call itself recursively, and do not call each other either directly or indirectly. Therefore, the g_warnings_mutex could be a non-recursive mutex.

    Related to #19180.

  2. refactor: Replace RecursiveMutex with Mutex in warnings.cpp bacbfb61ee
  3. fanquake added the label Refactoring on Jun 9, 2020
  4. laanwj commented at 12:16 PM on June 9, 2020: member

    Code review ACK bacbfb61eee6d3c32de3db4dea3f585c7159b643

  5. MarcoFalke commented at 12:20 PM on June 9, 2020: member

    ACK bacbfb61eee6d3c32de3db4dea3f585c7159b643 , reviewed with -W --word-diff-regex=. 🎿

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK bacbfb61eee6d3c32de3db4dea3f585c7159b643 , reviewed with -W  --word-diff-regex=. 🎿
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiNVwv7BTUKm0GB9t+drROb1BDLwWql8lD9EaM4f5ukGtHojWIZXoNFaQ25v/KS
KeBFQbVK1NhRiZzTtJylLAhlpbnCiLpDHYmm09sYk1OOp48voQyyPvum34qpSz7T
6z6+A6UACwl/yQ40DCuV3IU8UMJS8UtQ3nMd6jt70E0UCFxgcAn3afoSmLqs1iEY
PyZNCZLqEZHUgi9x5xSqf9ybiKYGC2XIoXLy/F6A89gU0SIsO6yqqvgXT4hHRUJz
4sIv0kdsT/zrCr3roKYz+BQ/RP+3wlIR9kz7GAncyBH8jRA8yo6tfm/usJee2yvr
toGCMJyE9E95xyK5CoVT84SSj3GP1z+vRcHWi4qPqfgpse3fIx/BH62ihmMS4V7d
0vUHBwkNe/yXtpv3fvg7VSCHpqWe0YK7sMn9eurlZ19hn1PJJUxcC1flwMROaPMc
ozyQdspDkPmQ4OAQ4WOvn6AQG2ZnamkIW+9sblysmXaqYlr0gafjxgOtYgRFKEG4
IW3aR7eY
=d+Dm
-----END PGP SIGNATURE-----

    Timestamp of file with hash b07688cbd9e25ed02fe7ebea576b8ab8f2164aa6a4bbc8090be738e095be29b1 -

    </details>

  6. MarcoFalke merged this on Jun 9, 2020
  7. MarcoFalke closed this on Jun 9, 2020
  8. hebasto deleted the branch on Jun 9, 2020
  9. deadalnix referenced this in commit 8debe9e531 on Mar 10, 2021
  10. PastaPastaPasta referenced this in commit 40f173954b on Jun 27, 2021
  11. PastaPastaPasta referenced this in commit 6c258b1f13 on Jun 28, 2021
  12. PastaPastaPasta referenced this in commit b192adca4f on Jun 29, 2021
  13. PastaPastaPasta referenced this in commit 7eb2b2f910 on Sep 17, 2021
  14. PastaPastaPasta referenced this in commit 12b5cfcff0 on Sep 19, 2021
  15. thelazier referenced this in commit d9423ace44 on Sep 25, 2021
  16. DrahtBot locked this on Feb 15, 2022
Contributors
hebastolaanwjMarcoFalke
Labels
Refactoring
Linked (view graph)
#19180 refactor: Replace RecursiveMutex with Mutex in Shutdown()#19303 Replace all of the RecursiveMutex instances with the Mutex ones
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me