CKey::Sign : switch test arg to explicit additional entropy argument #19269

pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:sign_entropy changing 5 files +134 −136
  1. instagibbs commented at 6:28 PM on June 13, 2020: member

    Previously a uint32_t was being given as an additional entropy to the nonce generating function whenever it was non-zero for testing purposes.

    This PR allows a full 32-byte chunk of entropy to be given to the generating function. Nonce grinding continues as before by incrementing the value by one each time and re-signing.

    Speculative future possible uses:

    1. Mitigation to fault attacks against deterministic nonce ECDSA by grabbing fresh entropy for each signature: https://eprint.iacr.org/2017/1014.pdf
    2. Sign-to-contract(swap out nonce function as well of course)

    I found updating the json tests a bit annoying, so I also made a commit that I can break out into its own PR.

  2. Move manually generated nullfail tests out of auto-generated section 68abeb0cb7
  3. CKey::Sign : switch test arg to explicit additional entropy argument b649622d74
  4. DrahtBot added the label Tests on Jun 13, 2020
  5. DrahtBot added the label Utils/log/libs on Jun 13, 2020
  6. MarcoFalke removed the label Tests on Jun 14, 2020
  7. instagibbs commented at 3:23 PM on August 10, 2020: member

    guess there's no interest for extremely theoretical issues :)

  8. instagibbs closed this on Aug 10, 2020

  9. DrahtBot locked this on Feb 15, 2022
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me