ci: Move travis workarounds to .travis.yml #19276

1. 
   MarcoFalke commented at 2:52 pm on June 14, 2020: member

   It seems odd to have travis related workarounds in the general ci config files. Fix that oddity by moving the travis related workarounds to the travis yaml file.

   For unexplained reasons, this should also work around and thus close #19171

2. MarcoFalke force-pushed on Jun 14, 2020
3. MarcoFalke force-pushed on Jun 14, 2020
4. ci: Move travis workarounds to .travis.yml fa71667597
5. MarcoFalke force-pushed on Jun 14, 2020
6. 
   MarcoFalke commented at 4:47 pm on June 14, 2020: member

   Run 1 passed: https://travis-ci.org/github/bitcoin/bitcoin/builds/698236561
7. MarcoFalke closed this on Jun 14, 2020

   ---

8. MarcoFalke reopened this on Jun 14, 2020

   ---

9. DrahtBot added the label Tests on Jun 14, 2020
10. 
    hebasto commented at 5:50 pm on June 14, 2020: member

    Has anyone an explanation?
11. in ci/test/05_before_script.sh:37 in fa71667597

    32@@ -33,9 +33,7 @@ if [ -z "$NO_DEPENDS" ]; then
    33   else
    34     SHELL_OPTS="CONFIG_SHELL="
    35   fi
    36-  # Temporary workaround for https://github.com/bitcoin/bitcoin/issues/16368
    37-  python3 -c 'import time; [print(".") or time.sleep(500) for _ in range(4)]' &
    

    ---

    ---

    

    MarcoFalke commented at 6:03 pm on June 14, 2020:

    I believe the issue was that this print did nothing, because by default flush=False (see https://docs.python.org/3.8/library/functions.html#print ).

    Testing locally and on travis x86, it did always happen to print, just not on travis arm.

12. in ci/test/06_script_b.sh:25 in fa71667597

    20@@ -21,8 +21,6 @@ if [ -n "$USE_VALGRIND" ]; then
    21   END_FOLD
    22 fi
    23 
    24-bash -c "${CI_WAIT}" &  # Print dots in case the tests take a long time to run
    25-
    

    ---

    ---

    

    hebasto commented at 7:04 pm on June 14, 2020:

    This deletion is also necessary?

    ---

    

    MarcoFalke commented at 8:43 pm on June 14, 2020:

    CI_WAIT no longer exists and this should be a no-op

    ---

    

    hebasto commented at 4:35 am on June 15, 2020:

    Yes, CI_WAIT was dropped from the .travis.yml in #18929.
13. hebasto approved
14. 
    hebasto commented at 4:36 am on June 15, 2020: member

    ACK fa7166759789c1282609ff3ab2e80d4f70910a9f, I have reviewed the code and it looks OK, I agree it can be merged.
15. MarcoFalke merged this on Jun 15, 2020
16. MarcoFalke closed this on Jun 15, 2020

    ---

17. MarcoFalke deleted the branch on Jun 15, 2020
18. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke hebasto

Labels
Tests