RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME #19282

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:gentoaddress_help_pkgname changing 1 files +1 −1

luke-jr commented at 8:14 AM on June 15, 2020: member

No description provided.
RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME 0f8f515445
fanquake added the label RPC/REST/ZMQ on Jun 15, 2020

in src/rpc/mining.cpp:255 in 0f8f515445

 251 | @@ -252,7 +252,7 @@ static UniValue generatetoaddress(const JSONRPCRequest& request)
 252 |                  RPCExamples{
 253 |              "\nGenerate 11 blocks to myaddress\n"
 254 |              + HelpExampleCli("generatetoaddress", "11 \"myaddress\"")
 255 | -            + "If you are running the bitcoin core wallet, you can get a new address to send the newly generated bitcoin to with:\n"
 256 | +            + "If you are using the " PACKAGE_NAME " wallet, you can get a new address to send the newly generated bitcoin to with:\n"

jonatack commented at 9:01 AM on June 15, 2020:

nit: either remove the colon, or add one at line 253 s/myaddress/myaddress:/

Looking at the other helps like listwallets, generatetodescriptor, etc., no colons seem to be used.

MarcoFalke commented at 10:13 AM on June 15, 2020:

RPCMan can take care of all formatting needs in the future. Instead of playing formatting ping-pong, I recommend to make progress on #18531

jonatack commented at 9:01 AM on June 15, 2020: member

ACK modulo nit
MarcoFalke merged this on Jun 15, 2020
MarcoFalke closed this on Jun 15, 2020
Fabcien referenced this in commit cbb9aa0191 on Jun 2, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels